Re: [PATCH 06/13] hw/ide: Extract bmdma_init_ops()

2023-04-26 Thread Mark Cave-Ayland
On 22/04/2023 16:07, Bernhard Beschow wrote: There are three private copies of bmdma_setup_bar() with small adaptions. Consolidate them into one public implementation. While at it rename the function to bmdma_init_ops() to reflect that the memory regions being initialized represent BMDMA operat

Re: [PATCH 06/13] hw/ide: Extract bmdma_init_ops()

2023-04-23 Thread Bernhard Beschow
Am 23. April 2023 17:43:22 UTC schrieb "Philippe Mathieu-Daudé" : >On 22/4/23 17:07, Bernhard Beschow wrote: >> There are three private copies of bmdma_setup_bar() with small adaptions. >> Consolidate them into one public implementation. >> >> While at it rename the function to bmdma_init_ops(

Re: [PATCH 06/13] hw/ide: Extract bmdma_init_ops()

2023-04-23 Thread Philippe Mathieu-Daudé
On 22/4/23 17:07, Bernhard Beschow wrote: There are three private copies of bmdma_setup_bar() with small adaptions. Consolidate them into one public implementation. While at it rename the function to bmdma_init_ops() to reflect that the memory regions being initialized represent BMDMA operations

[PATCH 06/13] hw/ide: Extract bmdma_init_ops()

2023-04-22 Thread Bernhard Beschow
There are three private copies of bmdma_setup_bar() with small adaptions. Consolidate them into one public implementation. While at it rename the function to bmdma_init_ops() to reflect that the memory regions being initialized represent BMDMA operations. The actual mapping as a PCI BAR is still p