Re: [PATCH 06/11] fdc: Fix fallback=auto error handling

2020-04-20 Thread Philippe Mathieu-Daudé
On 4/20/20 10:32 AM, Markus Armbruster wrote: fdctrl_realize_common() rejects fallback=auto. Used by devices "isa-fdc", "sysbus-fdc", "SUNW,fdtwo". The error handling is broken: $ qemu-system-x86_64 -nodefaults -device isa-fdc,fallback=auto,driveA=fd0 -drive if=none,id=fd0 ** E

[PATCH 06/11] fdc: Fix fallback=auto error handling

2020-04-20 Thread Markus Armbruster
fdctrl_realize_common() rejects fallback=auto. Used by devices "isa-fdc", "sysbus-fdc", "SUNW,fdtwo". The error handling is broken: $ qemu-system-x86_64 -nodefaults -device isa-fdc,fallback=auto,driveA=fd0 -drive if=none,id=fd0 ** ERROR:/work/armbru/qemu/hw/block/fdc.c:434:pick_driv