Re: [PATCH 06/10] fpu: Move m68k_denormal fmt flag into floatx80_behaviour

2025-02-21 Thread Richard Henderson
On 2/20/25 10:54, Peter Maydell wrote: On Thu, 20 Feb 2025 at 18:39, Richard Henderson wrote: On 2/20/25 09:12, Peter Maydell wrote: That suggests that we are correctly implementing the x87 required behaviour in QEMU, and so that the TODO comment I add in this patch isn't right. But then I'm

Re: [PATCH 06/10] fpu: Move m68k_denormal fmt flag into floatx80_behaviour

2025-02-21 Thread Philippe Mathieu-Daudé
On 20/2/25 19:54, Peter Maydell wrote: On Thu, 20 Feb 2025 at 18:39, Richard Henderson wrote: On 2/20/25 09:12, Peter Maydell wrote: That suggests that we are correctly implementing the x87 required behaviour in QEMU, and so that the TODO comment I add in this patch isn't right. But then I'm

Re: [PATCH 06/10] fpu: Move m68k_denormal fmt flag into floatx80_behaviour

2025-02-20 Thread Peter Maydell
On Thu, 20 Feb 2025 at 18:39, Richard Henderson wrote: > > On 2/20/25 09:12, Peter Maydell wrote: > > That suggests that we are correctly implementing the x87 > > required behaviour in QEMU, and so that the TODO comment > > I add in this patch isn't right. But then I'm a bit confused > > about wha

Re: [PATCH 06/10] fpu: Move m68k_denormal fmt flag into floatx80_behaviour

2025-02-20 Thread Richard Henderson
On 2/20/25 09:12, Peter Maydell wrote: That suggests that we are correctly implementing the x87 required behaviour in QEMU, and so that the TODO comment I add in this patch isn't right. But then I'm a bit confused about what the code is actually doing. Why do we need to look at fmt->m68k_denormal

Re: [PATCH 06/10] fpu: Move m68k_denormal fmt flag into floatx80_behaviour

2025-02-20 Thread Peter Maydell
On Mon, 17 Feb 2025 at 19:14, Richard Henderson wrote: > > On 2/17/25 04:50, Peter Maydell wrote: > > Currently we compile-time set an 'm68k_denormal' flag in the FloatFmt > > for floatx80 for m68k. This controls our handling of what the Intel > > documentation calls a "pseudo-denormal": a value

Re: [PATCH 06/10] fpu: Move m68k_denormal fmt flag into floatx80_behaviour

2025-02-17 Thread Richard Henderson
On 2/17/25 04:50, Peter Maydell wrote: Currently we compile-time set an 'm68k_denormal' flag in the FloatFmt for floatx80 for m68k. This controls our handling of what the Intel documentation calls a "pseudo-denormal": a value where the exponent field is zero and the explicit integer bit is set.

[PATCH 06/10] fpu: Move m68k_denormal fmt flag into floatx80_behaviour

2025-02-17 Thread Peter Maydell
Currently we compile-time set an 'm68k_denormal' flag in the FloatFmt for floatx80 for m68k. This controls our handling of what the Intel documentation calls a "pseudo-denormal": a value where the exponent field is zero and the explicit integer bit is set. For x86, the x87 FPU is supposed to acce