Re: [PATCH 05/13] hw/ide: Extract pci_ide_class_init()

2023-04-26 Thread Bernhard Beschow
Am 26. April 2023 11:04:30 UTC schrieb Mark Cave-Ayland : >On 22/04/2023 16:07, Bernhard Beschow wrote: > >> Resolves redundant code in every PCI IDE device model. > >I think this needs to mention that it's moving the PCIDeviceClass::exit() >function from all of the PCI IDE controller implemen

Re: [PATCH 05/13] hw/ide: Extract pci_ide_class_init()

2023-04-26 Thread Mark Cave-Ayland
On 22/04/2023 16:07, Bernhard Beschow wrote: Resolves redundant code in every PCI IDE device model. I think this needs to mention that it's moving the PCIDeviceClass::exit() function from all of the PCI IDE controller implementations to a common implementation in the parent PCI_IDE type.

Re: [PATCH 05/13] hw/ide: Extract pci_ide_class_init()

2023-04-23 Thread BALATON Zoltan
On Sun, 23 Apr 2023, Bernhard Beschow wrote: Am 23. April 2023 17:41:33 UTC schrieb "Philippe Mathieu-Daudé" : On 22/4/23 17:07, Bernhard Beschow wrote: Resolves redundant code in every PCI IDE device model. --- include/hw/ide/pci.h | 1 - hw/ide/cmd646.c | 15 --- hw/ide

Re: [PATCH 05/13] hw/ide: Extract pci_ide_class_init()

2023-04-23 Thread Bernhard Beschow
Am 23. April 2023 17:41:33 UTC schrieb "Philippe Mathieu-Daudé" : >On 22/4/23 17:07, Bernhard Beschow wrote: >> Resolves redundant code in every PCI IDE device model. >> --- >> include/hw/ide/pci.h | 1 - >> hw/ide/cmd646.c | 15 --- >> hw/ide/pci.c | 25 ++

Re: [PATCH 05/13] hw/ide: Extract pci_ide_class_init()

2023-04-23 Thread Philippe Mathieu-Daudé
On 22/4/23 17:07, Bernhard Beschow wrote: Resolves redundant code in every PCI IDE device model. --- include/hw/ide/pci.h | 1 - hw/ide/cmd646.c | 15 --- hw/ide/pci.c | 25 - hw/ide/piix.c| 19 --- hw/ide/sii3112.c

Re: [PATCH 05/13] hw/ide: Extract pci_ide_class_init()

2023-04-22 Thread Bernhard Beschow
Am 22. April 2023 17:34:30 UTC schrieb BALATON Zoltan : >On Sat, 22 Apr 2023, Bernhard Beschow wrote: >> Resolves redundant code in every PCI IDE device model. > >This patch could be broken up a bit more as it seems to do unrelated changes. >Such as setting DEVICE_CATEGORY_STORAGE in a differen

Re: [PATCH 05/13] hw/ide: Extract pci_ide_class_init()

2023-04-22 Thread BALATON Zoltan
On Sat, 22 Apr 2023, Bernhard Beschow wrote: Resolves redundant code in every PCI IDE device model. This patch could be broken up a bit more as it seems to do unrelated changes. Such as setting DEVICE_CATEGORY_STORAGE in a different way could be a separate patch to make it simpler to review.

[PATCH 05/13] hw/ide: Extract pci_ide_class_init()

2023-04-22 Thread Bernhard Beschow
Resolves redundant code in every PCI IDE device model. --- include/hw/ide/pci.h | 1 - hw/ide/cmd646.c | 15 --- hw/ide/pci.c | 25 - hw/ide/piix.c| 19 --- hw/ide/sii3112.c | 3 ++- hw/ide/via.c | 15 --