Re: [PATCH 05/12] hw/smbios: Dumb down smbios_entry_add() stub

2023-02-07 Thread Juan Quintela
Markus Armbruster wrote: > The QERR_ macros are leftovers from the days of "rich" error objects. > We've been trying to reduce their remaining use. > > smbios_entry_add() is only ever called on behalf of CLI option > -smbios. Since qemu-options.hx sets @arch_mask to QEMU_ARCH_I386 | > QEMU_ARCH_A

[PATCH 05/12] hw/smbios: Dumb down smbios_entry_add() stub

2023-02-06 Thread Markus Armbruster
The QERR_ macros are leftovers from the days of "rich" error objects. We've been trying to reduce their remaining use. smbios_entry_add() is only ever called on behalf of CLI option -smbios. Since qemu-options.hx sets @arch_mask to QEMU_ARCH_I386 | QEMU_ARCH_ARM, it is reachable only for these ta