Re: [PATCH 04/67] target/arm: Convert CRC32, CRC32C to decodetree

2024-12-02 Thread Richard Henderson
On 12/2/24 08:01, Philippe Mathieu-Daudé wrote: -    if (!dc_isar_feature(aa64_crc32, s) -    || (sf == 1 && sz != 3) -    || (sf == 0 && sz == 3)) { We are not checking the sf bit anymore, is that intended? Yes. +CRC32   0 00 11010110 . 0100 00 . . @rrr_b +CRC32

Re: [PATCH 04/67] target/arm: Convert CRC32, CRC32C to decodetree

2024-12-02 Thread Philippe Mathieu-Daudé
Hi Richard, On 1/12/24 16:05, Richard Henderson wrote: Signed-off-by: Richard Henderson --- target/arm/tcg/translate-a64.c | 101 + target/arm/tcg/a64.decode | 12 2 files changed, 53 insertions(+), 60 deletions(-) diff --git a/target/arm/tcg/tran

Re: [PATCH 04/67] target/arm: Convert CRC32, CRC32C to decodetree

2024-12-02 Thread Philippe Mathieu-Daudé
On 2/12/24 18:49, Richard Henderson wrote: On 12/2/24 08:01, Philippe Mathieu-Daudé wrote: -    if (!dc_isar_feature(aa64_crc32, s) -    || (sf == 1 && sz != 3) -    || (sf == 0 && sz == 3)) { We are not checking the sf bit anymore, is that intended? Yes. +CRC32   0 00 1101

[PATCH 04/67] target/arm: Convert CRC32, CRC32C to decodetree

2024-12-01 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/tcg/translate-a64.c | 101 + target/arm/tcg/a64.decode | 12 2 files changed, 53 insertions(+), 60 deletions(-) diff --git a/target/arm/tcg/translate-a64.c b/target/arm/tcg/translate-a64.c index 8b7ca2c68a