Re: [PATCH 04/67] iotests.py: create_test_image, remove_test_image

2019-10-02 Thread John Snow
On 10/2/19 7:00 AM, Max Reitz wrote: > On 02.10.19 01:20, John Snow wrote: >> >> >> On 10/1/19 3:46 PM, Max Reitz wrote: >>> Python tests should use these two new functions instead of >>> qemu_img('create', ...) + os.remove(), so that user-supplied image >>> options are interpreted and handled c

Re: [PATCH 04/67] iotests.py: create_test_image, remove_test_image

2019-10-02 Thread Max Reitz
On 02.10.19 01:20, John Snow wrote: > > > On 10/1/19 3:46 PM, Max Reitz wrote: >> Python tests should use these two new functions instead of >> qemu_img('create', ...) + os.remove(), so that user-supplied image >> options are interpreted and handled correctly. >> >> Signed-off-by: Max Reitz >> -

Re: [PATCH 04/67] iotests.py: create_test_image, remove_test_image

2019-10-01 Thread John Snow
On 10/1/19 7:20 PM, John Snow wrote: > You can write "if not 'key-secret' in opts" Ah nah, because it's key-secret= whatever and I'm just being too hasty with what I thought is actually in the opts list. Carry on ...

Re: [PATCH 04/67] iotests.py: create_test_image, remove_test_image

2019-10-01 Thread John Snow
On 10/1/19 3:46 PM, Max Reitz wrote: > Python tests should use these two new functions instead of > qemu_img('create', ...) + os.remove(), so that user-supplied image > options are interpreted and handled correctly. > > Signed-off-by: Max Reitz > --- > tests/qemu-iotests/iotests.py | 56 +

[PATCH 04/67] iotests.py: create_test_image, remove_test_image

2019-10-01 Thread Max Reitz
Python tests should use these two new functions instead of qemu_img('create', ...) + os.remove(), so that user-supplied image options are interpreted and handled correctly. Signed-off-by: Max Reitz --- tests/qemu-iotests/iotests.py | 56 +++ 1 file changed, 56 ins