Re: [PATCH 04/46] macio: Tidy up error handling in macio_newworld_realize()

2020-06-25 Thread Vladimir Sementsov-Ogievskiy
24.06.2020 19:43, Markus Armbruster wrote: macio_newworld_realize() effectively ignores ns->gpio realization errors, leaking the Error object. Fortunately, macio_gpio_realize() can't actually fail. Tidy up. Cc: Mark Cave-Ayland Cc: David Gibson Signed-off-by: Markus Armbruster Reviewed-by:

Re: [PATCH 04/46] macio: Tidy up error handling in macio_newworld_realize()

2020-06-24 Thread David Gibson
On Wed, Jun 24, 2020 at 06:43:02PM +0200, Markus Armbruster wrote: > macio_newworld_realize() effectively ignores ns->gpio realization > errors, leaking the Error object. Fortunately, macio_gpio_realize() > can't actually fail. Tidy up. > > Cc: Mark Cave-Ayland > Cc: David Gibson > Signed-off-

Re: [PATCH 04/46] macio: Tidy up error handling in macio_newworld_realize()

2020-06-24 Thread Eric Blake
On 6/24/20 11:43 AM, Markus Armbruster wrote: macio_newworld_realize() effectively ignores ns->gpio realization errors, leaking the Error object. Fortunately, macio_gpio_realize() can't actually fail. Tidy up. Cc: Mark Cave-Ayland Cc: David Gibson Signed-off-by: Markus Armbruster --- hw/m

[PATCH 04/46] macio: Tidy up error handling in macio_newworld_realize()

2020-06-24 Thread Markus Armbruster
macio_newworld_realize() effectively ignores ns->gpio realization errors, leaking the Error object. Fortunately, macio_gpio_realize() can't actually fail. Tidy up. Cc: Mark Cave-Ayland Cc: David Gibson Signed-off-by: Markus Armbruster --- hw/misc/macio/macio.c | 4 +++- 1 file changed, 3 ins