Re: [PATCH 04/20] xics: Eliminate reset hook

2019-09-25 Thread David Gibson
On Wed, Sep 25, 2019 at 09:59:52AM +0200, Greg Kurz wrote: > On Wed, 25 Sep 2019 16:45:18 +1000 > David Gibson wrote: > > > Currently TYPE_XICS_BASE and TYPE_XICS_SIMPLE have their own reset methods, > > using the standard technique for having the subtype call the supertype's > > methods before d

Re: [PATCH 04/20] xics: Eliminate reset hook

2019-09-25 Thread Greg Kurz
On Wed, 25 Sep 2019 16:45:18 +1000 David Gibson wrote: > Currently TYPE_XICS_BASE and TYPE_XICS_SIMPLE have their own reset methods, > using the standard technique for having the subtype call the supertype's > methods before doing its own thing. > > But TYPE_XICS_SIMPLE is the only subtype of TY

Re: [PATCH 04/20] xics: Eliminate reset hook

2019-09-25 Thread Cédric Le Goater
On 25/09/2019 08:45, David Gibson wrote: > Currently TYPE_XICS_BASE and TYPE_XICS_SIMPLE have their own reset methods, > using the standard technique for having the subtype call the supertype's > methods before doing its own thing. > > But TYPE_XICS_SIMPLE is the only subtype of TYPE_XICS_BASE eve

[PATCH 04/20] xics: Eliminate reset hook

2019-09-24 Thread David Gibson
Currently TYPE_XICS_BASE and TYPE_XICS_SIMPLE have their own reset methods, using the standard technique for having the subtype call the supertype's methods before doing its own thing. But TYPE_XICS_SIMPLE is the only subtype of TYPE_XICS_BASE ever instantiated, so there's no point having the spli