Re: [PATCH 04/10] hw/isa: Add the ISA_IRQ_TPM_DEFAULT definition

2020-10-13 Thread Stefan Berger
On 10/13/20 4:26 AM, Philippe Mathieu-Daudé wrote: On 10/13/20 9:20 AM, Gerd Hoffmann wrote: On Sun, Oct 11, 2020 at 09:32:23PM +0200, Philippe Mathieu-Daudé wrote: The TPM TIS device uses IRQ #5 by default. Add this default definition to the IsaIrqNumber enum. IRQ 5 has no fixed assig

Re: [PATCH 04/10] hw/isa: Add the ISA_IRQ_TPM_DEFAULT definition

2020-10-13 Thread Philippe Mathieu-Daudé
On 10/13/20 9:20 AM, Gerd Hoffmann wrote: On Sun, Oct 11, 2020 at 09:32:23PM +0200, Philippe Mathieu-Daudé wrote: The TPM TIS device uses IRQ #5 by default. Add this default definition to the IsaIrqNumber enum. IRQ 5 has no fixed assignment. All kinds of add-on isa cards (sound, net) u

Re: [PATCH 04/10] hw/isa: Add the ISA_IRQ_TPM_DEFAULT definition

2020-10-13 Thread Gerd Hoffmann
On Sun, Oct 11, 2020 at 09:32:23PM +0200, Philippe Mathieu-Daudé wrote: > The TPM TIS device uses IRQ #5 by default. Add this > default definition to the IsaIrqNumber enum. IRQ 5 has no fixed assignment. All kinds of add-on isa cards (sound, net) used to use irq #5 by default because that one wa

Re: [PATCH 04/10] hw/isa: Add the ISA_IRQ_TPM_DEFAULT definition

2020-10-11 Thread Philippe Mathieu-Daudé
On 10/11/20 10:28 PM, Stefan Berger wrote: On 10/11/20 3:32 PM, Philippe Mathieu-Daudé wrote: The TPM TIS device uses IRQ #5 by default. Add this default definition to the IsaIrqNumber enum. Avoid magic values in the code, replace them by the newly introduced definition. Signed-off-by: Philipp

Re: [PATCH 04/10] hw/isa: Add the ISA_IRQ_TPM_DEFAULT definition

2020-10-11 Thread Stefan Berger
On 10/11/20 3:32 PM, Philippe Mathieu-Daudé wrote: The TPM TIS device uses IRQ #5 by default. Add this default definition to the IsaIrqNumber enum. Avoid magic values in the code, replace them by the newly introduced definition. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/isa/isa.h

[PATCH 04/10] hw/isa: Add the ISA_IRQ_TPM_DEFAULT definition

2020-10-11 Thread Philippe Mathieu-Daudé
The TPM TIS device uses IRQ #5 by default. Add this default definition to the IsaIrqNumber enum. Avoid magic values in the code, replace them by the newly introduced definition. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/isa/isa.h | 1 + hw/i386/acpi-build.c | 2 +- hw/ipmi/isa_ip