Re: [PATCH 04/10] hw/intc/arm_gic: Rename 'first_cpu' argument

2023-04-11 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > "hw/core/cpu.h" defines 'first_cpu' as QTAILQ_FIRST_RCU(&cpus). > > arm_gic_common_reset_irq_state() calls its second argument > 'first_cpu', producing a build failure when "hw/core/cpu.h" > is included: > > hw/intc/arm_gic_common.c:238:68: warning: omitting t

Re: [PATCH 04/10] hw/intc/arm_gic: Rename 'first_cpu' argument

2023-04-07 Thread Richard Henderson
On 4/7/23 21:23, Richard Henderson wrote: On 4/5/23 09:04, Philippe Mathieu-Daudé wrote: "hw/core/cpu.h" defines 'first_cpu' as QTAILQ_FIRST_RCU(&cpus). arm_gic_common_reset_irq_state() calls its second argument 'first_cpu', producing a build failure when "hw/core/cpu.h" is included:    hw/int

Re: [PATCH 04/10] hw/intc/arm_gic: Rename 'first_cpu' argument

2023-04-07 Thread Richard Henderson
On 4/5/23 09:04, Philippe Mathieu-Daudé wrote: "hw/core/cpu.h" defines 'first_cpu' as QTAILQ_FIRST_RCU(&cpus). arm_gic_common_reset_irq_state() calls its second argument 'first_cpu', producing a build failure when "hw/core/cpu.h" is included: hw/intc/arm_gic_common.c:238:68: warning: omittin

[PATCH 04/10] hw/intc/arm_gic: Rename 'first_cpu' argument

2023-04-05 Thread Philippe Mathieu-Daudé
"hw/core/cpu.h" defines 'first_cpu' as QTAILQ_FIRST_RCU(&cpus). arm_gic_common_reset_irq_state() calls its second argument 'first_cpu', producing a build failure when "hw/core/cpu.h" is included: hw/intc/arm_gic_common.c:238:68: warning: omitting the parameter name in a function definition is