Re: [PATCH 03/28] tests/qapi-schema: Rework comments on longhand member definitions

2021-03-23 Thread John Snow
On 3/23/21 5:40 AM, Markus Armbruster wrote: A few old comments talk about "desired future use of defaults" and "anonymous inline branch types". Kind of misleading since commit 87adbbffd4 "qapi: add a dictionary form for TYPE" added longhand member definitions. Talk about that instead. Signed-

Re: [PATCH 03/28] tests/qapi-schema: Rework comments on longhand member definitions

2021-03-23 Thread John Snow
On 3/23/21 9:58 AM, Eric Blake wrote: On 3/23/21 8:00 AM, John Snow wrote: On 3/23/21 5:40 AM, Markus Armbruster wrote: +# event 'data' member with dict value is (longhand) argument +# definition, not inline complex type I have to be a weenie and say I don't know exactly what this comment is

Re: [PATCH 03/28] tests/qapi-schema: Rework comments on longhand member definitions

2021-03-23 Thread Eric Blake
On 3/23/21 4:40 AM, Markus Armbruster wrote: > A few old comments talk about "desired future use of defaults" and > "anonymous inline branch types". Kind of misleading since commit > 87adbbffd4 "qapi: add a dictionary form for TYPE" added longhand > member definitions. Talk about that instead. >

Re: [PATCH 03/28] tests/qapi-schema: Rework comments on longhand member definitions

2021-03-23 Thread Eric Blake
On 3/23/21 8:00 AM, John Snow wrote: > On 3/23/21 5:40 AM, Markus Armbruster wrote: >> +# event 'data' member with dict value is (longhand) argument >> +# definition, not inline complex type > > I have to be a weenie and say I don't know exactly what this comment is > telling me. > > (1) What's a

Re: [PATCH 03/28] tests/qapi-schema: Rework comments on longhand member definitions

2021-03-23 Thread John Snow
On 3/23/21 5:40 AM, Markus Armbruster wrote: +# event 'data' member with dict value is (longhand) argument +# definition, not inline complex type I have to be a weenie and say I don't know exactly what this comment is telling me. (1) What's a longhand argument? (2) What's an inline complex t

[PATCH 03/28] tests/qapi-schema: Rework comments on longhand member definitions

2021-03-23 Thread Markus Armbruster
A few old comments talk about "desired future use of defaults" and "anonymous inline branch types". Kind of misleading since commit 87adbbffd4 "qapi: add a dictionary form for TYPE" added longhand member definitions. Talk about that instead. Signed-off-by: Markus Armbruster --- tests/qapi-sche