Re: [PATCH 03/15] hw/riscv/sifive_u: use 'fdt' from MachineState

2022-12-23 Thread Bin Meng
On Thu, Dec 22, 2022 at 2:29 AM Daniel Henrique Barboza wrote: > > The MachineState object provides a 'fdt' pointer that is already being > used by other RISC-V machines, and it's also used by the 'dumpdtb' QMP > command. > > Remove the 'fdt' pointer from SiFiveUState and use MachineState::fdt > i

Re: [PATCH 03/15] hw/riscv/sifive_u: use 'fdt' from MachineState

2022-12-22 Thread Alistair Francis
On Thu, Dec 22, 2022 at 4:29 AM Daniel Henrique Barboza wrote: > > The MachineState object provides a 'fdt' pointer that is already being > used by other RISC-V machines, and it's also used by the 'dumpdtb' QMP > command. > > Remove the 'fdt' pointer from SiFiveUState and use MachineState::fdt > i

Re: [PATCH 03/15] hw/riscv/sifive_u: use 'fdt' from MachineState

2022-12-22 Thread Philippe Mathieu-Daudé
On 21/12/22 19:22, Daniel Henrique Barboza wrote: The MachineState object provides a 'fdt' pointer that is already being used by other RISC-V machines, and it's also used by the 'dumpdtb' QMP command. Remove the 'fdt' pointer from SiFiveUState and use MachineState::fdt instead. Cc: Palmer Dabbe

[PATCH 03/15] hw/riscv/sifive_u: use 'fdt' from MachineState

2022-12-21 Thread Daniel Henrique Barboza
The MachineState object provides a 'fdt' pointer that is already being used by other RISC-V machines, and it's also used by the 'dumpdtb' QMP command. Remove the 'fdt' pointer from SiFiveUState and use MachineState::fdt instead. Cc: Palmer Dabbelt Signed-off-by: Daniel Henrique Barboza --- hw/