Re: [PATCH 03/14] accel/tcg: Suppress auto-invalidate in probe_access_internal

2022-08-23 Thread Richard Henderson
On 8/23/22 08:19, Richard Henderson wrote: On 8/23/22 02:19, David Hildenbrand wrote: 1) s390_probe_access() documents to "With nonfault=1, return the PGM_ exception that would have been injected into the guest; return 0 if no exception was detected." But in case of CONFIG_USER_ONLY, we return

Re: [PATCH 03/14] accel/tcg: Suppress auto-invalidate in probe_access_internal

2022-08-23 Thread Richard Henderson
On 8/23/22 02:19, David Hildenbrand wrote: 1) s390_probe_access() documents to "With nonfault=1, return the PGM_ exception that would have been injected into the guest; return 0 if no exception was detected." But in case of CONFIG_USER_ONLY, we return the flags returned by s390_probe_access(), n

Re: [PATCH 03/14] accel/tcg: Suppress auto-invalidate in probe_access_internal

2022-08-23 Thread David Hildenbrand
On 23.08.22 01:57, Richard Henderson wrote: > When PAGE_WRITE_INV is set when calling tlb_set_page, > we immediately set TLB_INVALID_MASK in order to force > tlb_fill to be called on the next lookup. Here in > probe_access_internal, we have just called tlb_fill > and eliminated true misses, thus t

[PATCH 03/14] accel/tcg: Suppress auto-invalidate in probe_access_internal

2022-08-22 Thread Richard Henderson
When PAGE_WRITE_INV is set when calling tlb_set_page, we immediately set TLB_INVALID_MASK in order to force tlb_fill to be called on the next lookup. Here in probe_access_internal, we have just called tlb_fill and eliminated true misses, thus the lookup must be valid. This allows us to remove a w