Re: [PATCH 02/36] target/arm: Don't allow Thumb Neon insns without FEATURE_NEON

2020-05-01 Thread Philippe Mathieu-Daudé
On 4/30/20 8:09 PM, Peter Maydell wrote: We were accidentally permitting decode of Thumb Neon insns even if the CPU didn't have the FEATURE_NEON bit set, because the feature check was being done before the call to disas_neon_data_insn() and disas_neon_ls_insn() in the Arm decoder but was omitted

Re: [PATCH 02/36] target/arm: Don't allow Thumb Neon insns without FEATURE_NEON

2020-04-30 Thread Richard Henderson
On 4/30/20 11:09 AM, Peter Maydell wrote: > We were accidentally permitting decode of Thumb Neon insns even if > the CPU didn't have the FEATURE_NEON bit set, because the feature > check was being done before the call to disas_neon_data_insn() and > disas_neon_ls_insn() in the Arm decoder but was o

[PATCH 02/36] target/arm: Don't allow Thumb Neon insns without FEATURE_NEON

2020-04-30 Thread Peter Maydell
We were accidentally permitting decode of Thumb Neon insns even if the CPU didn't have the FEATURE_NEON bit set, because the feature check was being done before the call to disas_neon_data_insn() and disas_neon_ls_insn() in the Arm decoder but was omitted from the Thumb decoder. Push the feature b