Re: [PATCH 02/33] Disable clang warnings arising from bsd-user/qemu.h

2023-08-08 Thread Warner Losh
On Tue, Aug 8, 2023 at 9:05 PM Richard Henderson < richard.hender...@linaro.org> wrote: > On 8/8/23 19:56, Warner Losh wrote: > > Looking at this now, This bug is in clang 7, from 2018. For FreeBSD, we > don't support > > anything older than clang 12 or 13 However, the bug still exists in > clang

Re: [PATCH 02/33] Disable clang warnings arising from bsd-user/qemu.h

2023-08-08 Thread Richard Henderson
On 8/8/23 19:56, Warner Losh wrote: Looking at this now, This bug is in clang 7, from 2018. For FreeBSD, we don't support anything older than clang 12 or 13 However, the bug still exists in clang 16, the latest. I believe this was also copied verbatim from linux-user, so let's leave it and the

Re: [PATCH 02/33] Disable clang warnings arising from bsd-user/qemu.h

2023-08-08 Thread Warner Losh
On Tue, Aug 8, 2023 at 2:50 PM Richard Henderson < richard.hender...@linaro.org> wrote: > On 8/7/23 23:07, Karim Taha wrote: > > +/* > > + * Tricky points: > > + * - Use __builtin_choose_expr to avoid type promotion from ?:, > > + * - Invalid sizes result in a compile time error stemming from > >

Re: [PATCH 02/33] Disable clang warnings arising from bsd-user/qemu.h

2023-08-08 Thread Richard Henderson
On 8/7/23 23:07, Karim Taha wrote: +/* + * Tricky points: + * - Use __builtin_choose_expr to avoid type promotion from ?:, + * - Invalid sizes result in a compile time error stemming from + * the fact that abort has no parameters. + * - It's easier to use the endian-specific unaligned load/stor

[PATCH 02/33] Disable clang warnings arising from bsd-user/qemu.h

2023-08-08 Thread Karim Taha
From: Kyle Evans Implement PRAGMA_DISABLE_PACKED_WARNING and PRAGMA_REENABLE_PACKED_WARNING macros in bsd-user/qemu.h. Signed-off-by: Kyle Evans Signed-off-by: Karim Taha --- bsd-user/qemu.h | 31 +++ 1 file changed, 31 insertions(+) diff --git a/bsd-user/qemu.h