Re: [PATCH 02/25] qemu-option: move help handling to get_opt_name_value

2021-01-19 Thread Markus Armbruster
Paolo Bonzini writes: > Right now, help options are parsed normally and then checked > specially in opt_validate, but only if coming from > qemu_opts_parse_noisily. has_help_option does the check on its own. > > opt_validate() has two callers: qemu_opt_set(), which passes null and is > therefore

[PATCH 02/25] qemu-option: move help handling to get_opt_name_value

2021-01-18 Thread Paolo Bonzini
Right now, help options are parsed normally and then checked specially in opt_validate, but only if coming from qemu_opts_parse_noisily. has_help_option does the check on its own. opt_validate() has two callers: qemu_opt_set(), which passes null and is therefore unaffected, and opts_do_parse(), w