Re: [PATCH 02/21] hw/arm/mps2: Use the IEC binary prefix definitions

2019-10-21 Thread Alistair Francis
On Sun, Oct 20, 2019 at 4:02 PM Philippe Mathieu-Daudé wrote: > > IEC binary prefixes ease code review: the unit is explicit. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Alistair > --- > hw/arm/mps2-tz.c | 3 ++- > hw/arm/mps2.c| 3 ++- > 2 files changed, 4 in

Re: [PATCH 02/21] hw/arm/mps2: Use the IEC binary prefix definitions

2019-10-21 Thread Richard Henderson
On 10/20/19 3:56 PM, Philippe Mathieu-Daudé wrote: > IEC binary prefixes ease code review: the unit is explicit. > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/arm/mps2-tz.c | 3 ++- > hw/arm/mps2.c| 3 ++- > 2 files changed, 4 insertions(+), 2 deletions(-) Reviewed-by: Richard Hender

[PATCH 02/21] hw/arm/mps2: Use the IEC binary prefix definitions

2019-10-20 Thread Philippe Mathieu-Daudé
IEC binary prefixes ease code review: the unit is explicit. Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/mps2-tz.c | 3 ++- hw/arm/mps2.c| 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/hw/arm/mps2-tz.c b/hw/arm/mps2-tz.c index 6b24aaacde..f8b620bcc6 100644 --- a/h