Re: [PATCH 02/17] replay: Fix migration replay_mutex locking

2024-12-20 Thread Nicholas Piggin
On Fri Dec 20, 2024 at 11:08 PM AEST, Fabiano Rosas wrote: > Nicholas Piggin writes: > > Hi Nick, > > I'm ignorant about replay, but we try to know why were taking the BQL in > the migration code, we move it around sometimes, etc. Can we be a bit > more strict with documentation here so we don't g

Re: [PATCH 02/17] replay: Fix migration replay_mutex locking

2024-12-20 Thread Fabiano Rosas
Nicholas Piggin writes: Hi Nick, I'm ignorant about replay, but we try to know why were taking the BQL in the migration code, we move it around sometimes, etc. Can we be a bit more strict with documentation here so we don't get stuck with a lock that can't be changed? > Migration causes a numbe

[PATCH 02/17] replay: Fix migration replay_mutex locking

2024-12-20 Thread Nicholas Piggin
Migration causes a number of events that need to go in the replay trace, such as vm state transitions. The replay_mutex lock needs to be held for these. The simplest approach seems to be just take it up-front when taking the bql. Signed-off-by: Nicholas Piggin --- migration/migration.c | 9