Re: [PATCH 02/11] target/riscv: allow users to actually write the MISA CSR

2023-02-14 Thread Daniel Henrique Barboza
On 2/14/23 12:12, weiwei wrote: On 2023/2/11 19:50, Daniel Henrique Barboza wrote: On 2/10/23 23:43, weiwei wrote: On 2023/2/10 21:36, Daniel Henrique Barboza wrote: At this moment, and apparently since ever, we have no way of enabling RISCV_FEATURE_MISA. This means that all the code fr

Re: [PATCH 02/11] target/riscv: allow users to actually write the MISA CSR

2023-02-14 Thread weiwei
On 2023/2/11 19:50, Daniel Henrique Barboza wrote: On 2/10/23 23:43, weiwei wrote: On 2023/2/10 21:36, Daniel Henrique Barboza wrote: At this moment, and apparently since ever, we have no way of enabling RISCV_FEATURE_MISA. This means that all the code from write_misa(), all the nuts and b

Re: [PATCH 02/11] target/riscv: allow users to actually write the MISA CSR

2023-02-11 Thread Daniel Henrique Barboza
On 2/10/23 23:43, weiwei wrote: On 2023/2/10 21:36, Daniel Henrique Barboza wrote: At this moment, and apparently since ever, we have no way of enabling RISCV_FEATURE_MISA. This means that all the code from write_misa(), all the nuts and bolts that handles how to properly write this CSR, has

Re: [PATCH 02/11] target/riscv: allow users to actually write the MISA CSR

2023-02-10 Thread weiwei
On 2023/2/10 21:36, Daniel Henrique Barboza wrote: At this moment, and apparently since ever, we have no way of enabling RISCV_FEATURE_MISA. This means that all the code from write_misa(), all the nuts and bolts that handles how to properly write this CSR, has always been a no-op as well becaus

[PATCH 02/11] target/riscv: allow users to actually write the MISA CSR

2023-02-10 Thread Daniel Henrique Barboza
At this moment, and apparently since ever, we have no way of enabling RISCV_FEATURE_MISA. This means that all the code from write_misa(), all the nuts and bolts that handles how to properly write this CSR, has always been a no-op as well because write_misa() will always exit earlier. This seems to