Re: [PATCH 02/10] numa: introduce MachineClass::forbid_asymmetrical_numa

2020-09-23 Thread John Snow
On 8/20/20 12:51 PM, Eduardo Habkost wrote: In either case, it sounds like this won't be a common constraint and I now agree with your original suggestion of doing this in machine initialization code. I'm late to this chat, but not every constraint needs to be modeled as data -- it's okay to

Re: [PATCH 02/10] numa: introduce MachineClass::forbid_asymmetrical_numa

2020-08-25 Thread David Gibson
On Tue, Aug 25, 2020 at 06:56:46AM -0300, Daniel Henrique Barboza wrote: > > > On 8/24/20 8:49 PM, David Gibson wrote: > > On Mon, Aug 24, 2020 at 08:45:12AM -0300, Daniel Henrique Barboza wrote: > > > > > > > > [...] > > > > > > LOPAPR support a somewhat asymmetrical NUMA setup in its curren

Re: [PATCH 02/10] numa: introduce MachineClass::forbid_asymmetrical_numa

2020-08-25 Thread Daniel Henrique Barboza
On 8/24/20 8:49 PM, David Gibson wrote: On Mon, Aug 24, 2020 at 08:45:12AM -0300, Daniel Henrique Barboza wrote: [...] LOPAPR support a somewhat asymmetrical NUMA setup in its current form, Huh, I didn't even realize that. What's the mechanism? LOPAPR mentions that a single resourc

Re: [PATCH 02/10] numa: introduce MachineClass::forbid_asymmetrical_numa

2020-08-24 Thread David Gibson
On Mon, Aug 24, 2020 at 08:45:12AM -0300, Daniel Henrique Barboza wrote: > > > On 8/24/20 3:08 AM, David Gibson wrote: > > On Fri, Aug 21, 2020 at 09:47:47AM -0300, Daniel Henrique Barboza wrote: > > > > > > > > > On 8/21/20 5:55 AM, Igor Mammedov wrote: > > > > On Thu, 20 Aug 2020 12:51:03 -04

Re: [PATCH 02/10] numa: introduce MachineClass::forbid_asymmetrical_numa

2020-08-24 Thread Daniel Henrique Barboza
On 8/24/20 3:08 AM, David Gibson wrote: On Fri, Aug 21, 2020 at 09:47:47AM -0300, Daniel Henrique Barboza wrote: On 8/21/20 5:55 AM, Igor Mammedov wrote: On Thu, 20 Aug 2020 12:51:03 -0400 Eduardo Habkost wrote: On Thu, Aug 20, 2020 at 02:15:04PM +1000, David Gibson wrote: On Wed, Aug

Re: [PATCH 02/10] numa: introduce MachineClass::forbid_asymmetrical_numa

2020-08-24 Thread David Gibson
On Fri, Aug 21, 2020 at 09:47:47AM -0300, Daniel Henrique Barboza wrote: > > > On 8/21/20 5:55 AM, Igor Mammedov wrote: > > On Thu, 20 Aug 2020 12:51:03 -0400 > > Eduardo Habkost wrote: > > > > > On Thu, Aug 20, 2020 at 02:15:04PM +1000, David Gibson wrote: > > > > On Wed, Aug 19, 2020 at 10:11

Re: [PATCH 02/10] numa: introduce MachineClass::forbid_asymmetrical_numa

2020-08-21 Thread Daniel Henrique Barboza
On 8/21/20 5:55 AM, Igor Mammedov wrote: On Thu, 20 Aug 2020 12:51:03 -0400 Eduardo Habkost wrote: On Thu, Aug 20, 2020 at 02:15:04PM +1000, David Gibson wrote: On Wed, Aug 19, 2020 at 10:11:28PM -0400, Eduardo Habkost wrote: On Thu, Aug 20, 2020 at 11:17:26AM +1000, David Gibson wrote:

Re: [PATCH 02/10] numa: introduce MachineClass::forbid_asymmetrical_numa

2020-08-21 Thread Igor Mammedov
On Thu, 20 Aug 2020 12:51:03 -0400 Eduardo Habkost wrote: > On Thu, Aug 20, 2020 at 02:15:04PM +1000, David Gibson wrote: > > On Wed, Aug 19, 2020 at 10:11:28PM -0400, Eduardo Habkost wrote: > > > On Thu, Aug 20, 2020 at 11:17:26AM +1000, David Gibson wrote: > > > > On Fri, Aug 14, 2020 at 05

Re: [PATCH 02/10] numa: introduce MachineClass::forbid_asymmetrical_numa

2020-08-20 Thread Eduardo Habkost
On Thu, Aug 20, 2020 at 02:15:04PM +1000, David Gibson wrote: > On Wed, Aug 19, 2020 at 10:11:28PM -0400, Eduardo Habkost wrote: > > On Thu, Aug 20, 2020 at 11:17:26AM +1000, David Gibson wrote: > > > On Fri, Aug 14, 2020 at 05:54:16PM -0300, Daniel Henrique Barboza wrote: > > > > The pSeries machi

Re: [PATCH 02/10] numa: introduce MachineClass::forbid_asymmetrical_numa

2020-08-20 Thread Igor Mammedov
On Thu, 20 Aug 2020 07:33:00 -0300 Daniel Henrique Barboza wrote: > On 8/20/20 1:15 AM, David Gibson wrote: > > On Wed, Aug 19, 2020 at 10:11:28PM -0400, Eduardo Habkost wrote: > >> On Thu, Aug 20, 2020 at 11:17:26AM +1000, David Gibson wrote: > >>> On Fri, Aug 14, 2020 at 05:54:16PM -0300, D

Re: [PATCH 02/10] numa: introduce MachineClass::forbid_asymmetrical_numa

2020-08-20 Thread Daniel Henrique Barboza
On 8/20/20 1:15 AM, David Gibson wrote: On Wed, Aug 19, 2020 at 10:11:28PM -0400, Eduardo Habkost wrote: On Thu, Aug 20, 2020 at 11:17:26AM +1000, David Gibson wrote: On Fri, Aug 14, 2020 at 05:54:16PM -0300, Daniel Henrique Barboza wrote: The pSeries machine does not support asymmetrical N

Re: [PATCH 02/10] numa: introduce MachineClass::forbid_asymmetrical_numa

2020-08-19 Thread David Gibson
On Wed, Aug 19, 2020 at 10:11:28PM -0400, Eduardo Habkost wrote: > On Thu, Aug 20, 2020 at 11:17:26AM +1000, David Gibson wrote: > > On Fri, Aug 14, 2020 at 05:54:16PM -0300, Daniel Henrique Barboza wrote: > > > The pSeries machine does not support asymmetrical NUMA > > > configurations. > > > > T

Re: [PATCH 02/10] numa: introduce MachineClass::forbid_asymmetrical_numa

2020-08-19 Thread Eduardo Habkost
On Thu, Aug 20, 2020 at 11:17:26AM +1000, David Gibson wrote: > On Fri, Aug 14, 2020 at 05:54:16PM -0300, Daniel Henrique Barboza wrote: > > The pSeries machine does not support asymmetrical NUMA > > configurations. > > This seems a bit oddly specific to have as a global machine class > property.

Re: [PATCH 02/10] numa: introduce MachineClass::forbid_asymmetrical_numa

2020-08-19 Thread David Gibson
On Fri, Aug 14, 2020 at 05:54:16PM -0300, Daniel Henrique Barboza wrote: > The pSeries machine does not support asymmetrical NUMA > configurations. This seems a bit oddly specific to have as a global machine class property. Would it make more sense for machines with specific NUMA constraints to j

[PATCH 02/10] numa: introduce MachineClass::forbid_asymmetrical_numa

2020-08-15 Thread Daniel Henrique Barboza
The pSeries machine does not support asymmetrical NUMA configurations. CC: Eduardo Habkost CC: Marcel Apfelbaum Signed-off-by: Daniel Henrique Barboza --- hw/core/numa.c | 7 +++ hw/ppc/spapr.c | 1 + include/hw/boards.h | 1 + 3 files changed, 9 insertions(+) diff --git a/hw/co