Re: [PATCH 02/10] hw: arm: add Xunlong Orange Pi PC machine

2019-12-10 Thread Niek Linnenbank
Hi Philippe, On Tue, Dec 10, 2019 at 9:59 AM Philippe Mathieu-Daudé wrote: > On 12/6/19 11:15 PM, Niek Linnenbank wrote: > [...] > > > > +static void orangepi_machine_init(MachineClass *mc) > > > > +{ > > > > +mc->desc = "Orange Pi PC"; > > > > +mc

Re: [PATCH 02/10] hw: arm: add Xunlong Orange Pi PC machine

2019-12-10 Thread Philippe Mathieu-Daudé
On 12/6/19 11:15 PM, Niek Linnenbank wrote: [...] >      > +static void orangepi_machine_init(MachineClass *mc) >      > +{ >      > +    mc->desc = "Orange Pi PC"; >      > +    mc->init = orangepi_init; >      > +    mc->units_per_default_bus = 1; >      > +    mc-

Re: [PATCH 02/10] hw: arm: add Xunlong Orange Pi PC machine

2019-12-06 Thread Niek Linnenbank
Hi Philippe, On Fri, Dec 6, 2019 at 6:41 AM Philippe Mathieu-Daudé wrote: > On 12/5/19 11:15 PM, Niek Linnenbank wrote: > > Hello Philippe, > > > > On Tue, Dec 3, 2019 at 10:18 AM Philippe Mathieu-Daudé > > mailto:phi...@redhat.com>> wrote: > > > > On 12/2/19 10:09 PM, Niek Linnenbank wrote:

Re: [PATCH 02/10] hw: arm: add Xunlong Orange Pi PC machine

2019-12-05 Thread Philippe Mathieu-Daudé
On 12/5/19 11:15 PM, Niek Linnenbank wrote: Hello Philippe, On Tue, Dec 3, 2019 at 10:18 AM Philippe Mathieu-Daudé mailto:phi...@redhat.com>> wrote: On 12/2/19 10:09 PM, Niek Linnenbank wrote: > The Xunlong Orange Pi PC is an Allwinner H3 System on Chip > based embedded computer

Re: [PATCH 02/10] hw: arm: add Xunlong Orange Pi PC machine

2019-12-05 Thread Niek Linnenbank
Hello Philippe, On Tue, Dec 3, 2019 at 10:18 AM Philippe Mathieu-Daudé wrote: > On 12/2/19 10:09 PM, Niek Linnenbank wrote: > > The Xunlong Orange Pi PC is an Allwinner H3 System on Chip > > based embedded computer with mainline support in both U-Boot > > and Linux. The board comes with a Quad C

Re: [PATCH 02/10] hw: arm: add Xunlong Orange Pi PC machine

2019-12-04 Thread Niek Linnenbank
On Wed, Dec 4, 2019 at 10:03 AM Philippe Mathieu-Daudé wrote: > On 12/3/19 8:33 PM, Niek Linnenbank wrote: > > Hello Philippe, > > > > Thanks for your quick review comments! > > I'll start working on a v2 of the patches and include the changes you > > suggested. > > Thanks, but I'd suggest to wai

Re: [PATCH 02/10] hw: arm: add Xunlong Orange Pi PC machine

2019-12-04 Thread Philippe Mathieu-Daudé
On 12/3/19 8:33 PM, Niek Linnenbank wrote: Hello Philippe, Thanks for your quick review comments! I'll start working on a v2 of the patches and include the changes you suggested. Thanks, but I'd suggest to wait few more days to give time to others reviewers. Else having multiple versions of

Re: [PATCH 02/10] hw: arm: add Xunlong Orange Pi PC machine

2019-12-03 Thread Niek Linnenbank
Hello Philippe, Thanks for your quick review comments! I'll start working on a v2 of the patches and include the changes you suggested. Regards, Niek On Tue, Dec 3, 2019 at 10:18 AM Philippe Mathieu-Daudé wrote: > On 12/2/19 10:09 PM, Niek Linnenbank wrote: > > The Xunlong Orange Pi PC is an A

Re: [PATCH 02/10] hw: arm: add Xunlong Orange Pi PC machine

2019-12-03 Thread Philippe Mathieu-Daudé
On 12/2/19 10:09 PM, Niek Linnenbank wrote: The Xunlong Orange Pi PC is an Allwinner H3 System on Chip based embedded computer with mainline support in both U-Boot and Linux. The board comes with a Quad Core Cortex A7 @ 1.3GHz, 512MB RAM, 100Mbit ethernet, USB, SD/MMC, USB, HDMI and various other

[PATCH 02/10] hw: arm: add Xunlong Orange Pi PC machine

2019-12-02 Thread Niek Linnenbank
The Xunlong Orange Pi PC is an Allwinner H3 System on Chip based embedded computer with mainline support in both U-Boot and Linux. The board comes with a Quad Core Cortex A7 @ 1.3GHz, 512MB RAM, 100Mbit ethernet, USB, SD/MMC, USB, HDMI and various other I/O. This commit add support for the Xunlong