Re: [PATCH 02/10] gdbstub: introduce target independent gdb register helper

2025-04-05 Thread Philippe Mathieu-Daudé
On 20/3/25 07:19, Akihiko Odaki wrote: On 2025/03/20 3:22, Alex Bennée wrote: The current helper.h functions rely on hard coded assumptions about target endianess to use the tswap macros. We also end up double swapping a bunch of values if the target can run in multiple endianess modes. Avoid th

Re: [PATCH 02/10] gdbstub: introduce target independent gdb register helper

2025-04-05 Thread Pierrick Bouvier
On 3/19/25 11:22, Alex Bennée wrote: The current helper.h functions rely on hard coded assumptions about target endianess to use the tswap macros. We also end up double swapping a bunch of values if the target can run in multiple endianess modes. Avoid this by getting the target to pass the endia

Re: [PATCH 02/10] gdbstub: introduce target independent gdb register helper

2025-03-21 Thread Pierrick Bouvier
On 3/21/25 04:36, Alex Bennée wrote: Pierrick Bouvier writes: On 3/20/25 12:30, Pierrick Bouvier wrote: On 3/19/25 11:22, Alex Bennée wrote: The current helper.h functions rely on hard coded assumptions about target endianess to use the tswap macros. We also end up double swapping a bunch of

Re: [PATCH 02/10] gdbstub: introduce target independent gdb register helper

2025-03-21 Thread Alex Bennée
Pierrick Bouvier writes: > On 3/20/25 12:30, Pierrick Bouvier wrote: >> On 3/19/25 11:22, Alex Bennée wrote: >>> The current helper.h functions rely on hard coded assumptions about >>> target endianess to use the tswap macros. We also end up double >>> swapping a bunch of values if the target can

Re: [PATCH 02/10] gdbstub: introduce target independent gdb register helper

2025-03-20 Thread Pierrick Bouvier
On 3/20/25 12:30, Pierrick Bouvier wrote: On 3/19/25 11:22, Alex Bennée wrote: The current helper.h functions rely on hard coded assumptions about target endianess to use the tswap macros. We also end up double swapping a bunch of values if the target can run in multiple endianess modes. Avoid t

Re: [PATCH 02/10] gdbstub: introduce target independent gdb register helper

2025-03-20 Thread Pierrick Bouvier
On 3/19/25 11:22, Alex Bennée wrote: The current helper.h functions rely on hard coded assumptions about target endianess to use the tswap macros. We also end up double swapping a bunch of values if the target can run in multiple endianess modes. Avoid this by getting the target to pass the endia

Re: [PATCH 02/10] gdbstub: introduce target independent gdb register helper

2025-03-20 Thread Akihiko Odaki
On 2025/03/20 3:22, Alex Bennée wrote: The current helper.h functions rely on hard coded assumptions about target endianess to use the tswap macros. We also end up double swapping a bunch of values if the target can run in multiple endianess modes. Avoid this by getting the target to pass the end

Re: [PATCH 02/10] gdbstub: introduce target independent gdb register helper

2025-03-20 Thread Philippe Mathieu-Daudé
Hi Alex, On 19/3/25 19:22, Alex Bennée wrote: The current helper.h functions rely on hard coded assumptions about target endianess to use the tswap macros. We also end up double swapping a bunch of values if the target can run in multiple endianess modes. Avoid this by getting the target to pass

[PATCH 02/10] gdbstub: introduce target independent gdb register helper

2025-03-19 Thread Alex Bennée
The current helper.h functions rely on hard coded assumptions about target endianess to use the tswap macros. We also end up double swapping a bunch of values if the target can run in multiple endianess modes. Avoid this by getting the target to pass the endianess and size via a MemOp and fixing up