Re: [PATCH 01/39] docs/spin: replace assert(0) with g_assert_not_reached()

2024-09-11 Thread Pierrick Bouvier
On 9/11/24 09:13, Thomas Huth wrote: On 11/09/2024 14.51, Richard W.M. Jones wrote: On Wed, Sep 11, 2024 at 02:46:18PM +0200, Maciej S. Szmigiero wrote: On 11.09.2024 14:37, Eric Blake wrote: On Wed, Sep 11, 2024 at 07:33:59AM GMT, Eric Blake wrote: On Tue, Sep 10, 2024 at 03:15:28PM GMT, Pie

Re: [PATCH 01/39] docs/spin: replace assert(0) with g_assert_not_reached()

2024-09-11 Thread Richard Henderson
On 9/11/24 08:25, Pierrick Bouvier wrote: On 9/11/24 05:51, Richard W.M. Jones wrote: Although it's unlikely to be used on any compiler that can also compile qemu, there is a third implementation of g_assert_not_reached that does nothing, see: https://gitlab.gnome.org/GNOME/glib/-/blob/927683eb

Re: [PATCH 01/39] docs/spin: replace assert(0) with g_assert_not_reached()

2024-09-11 Thread Thomas Huth
On 11/09/2024 14.51, Richard W.M. Jones wrote: On Wed, Sep 11, 2024 at 02:46:18PM +0200, Maciej S. Szmigiero wrote: On 11.09.2024 14:37, Eric Blake wrote: On Wed, Sep 11, 2024 at 07:33:59AM GMT, Eric Blake wrote: On Tue, Sep 10, 2024 at 03:15:28PM GMT, Pierrick Bouvier wrote: Signed-off-by: P

Re: [PATCH 01/39] docs/spin: replace assert(0) with g_assert_not_reached()

2024-09-11 Thread Pierrick Bouvier
On 9/11/24 05:51, Richard W.M. Jones wrote: On Wed, Sep 11, 2024 at 02:46:18PM +0200, Maciej S. Szmigiero wrote: On 11.09.2024 14:37, Eric Blake wrote: On Wed, Sep 11, 2024 at 07:33:59AM GMT, Eric Blake wrote: On Tue, Sep 10, 2024 at 03:15:28PM GMT, Pierrick Bouvier wrote: Signed-off-by: Pier

Re: [PATCH 01/39] docs/spin: replace assert(0) with g_assert_not_reached()

2024-09-11 Thread Pierrick Bouvier
On 9/11/24 05:37, Eric Blake wrote: On Wed, Sep 11, 2024 at 07:33:59AM GMT, Eric Blake wrote: On Tue, Sep 10, 2024 at 03:15:28PM GMT, Pierrick Bouvier wrote: Signed-off-by: Pierrick Bouvier --- A general suggestion for the entire series: please use a commit message that explains why this is

Re: [PATCH 01/39] docs/spin: replace assert(0) with g_assert_not_reached()

2024-09-11 Thread Richard W.M. Jones
On Wed, Sep 11, 2024 at 02:46:18PM +0200, Maciej S. Szmigiero wrote: > On 11.09.2024 14:37, Eric Blake wrote: > >On Wed, Sep 11, 2024 at 07:33:59AM GMT, Eric Blake wrote: > >>On Tue, Sep 10, 2024 at 03:15:28PM GMT, Pierrick Bouvier wrote: > >>>Signed-off-by: Pierrick Bouvier > >>>--- > >> > >>A ge

Re: [PATCH 01/39] docs/spin: replace assert(0) with g_assert_not_reached()

2024-09-11 Thread Maciej S. Szmigiero
On 11.09.2024 14:37, Eric Blake wrote: On Wed, Sep 11, 2024 at 07:33:59AM GMT, Eric Blake wrote: On Tue, Sep 10, 2024 at 03:15:28PM GMT, Pierrick Bouvier wrote: Signed-off-by: Pierrick Bouvier --- A general suggestion for the entire series: please use a commit message that explains why this

Re: [PATCH 01/39] docs/spin: replace assert(0) with g_assert_not_reached()

2024-09-11 Thread Eric Blake
On Wed, Sep 11, 2024 at 07:33:59AM GMT, Eric Blake wrote: > On Tue, Sep 10, 2024 at 03:15:28PM GMT, Pierrick Bouvier wrote: > > Signed-off-by: Pierrick Bouvier > > --- > > A general suggestion for the entire series: please use a commit > message that explains why this is a good idea. Even someth

Re: [PATCH 01/39] docs/spin: replace assert(0) with g_assert_not_reached()

2024-09-11 Thread Eric Blake
On Tue, Sep 10, 2024 at 03:15:28PM GMT, Pierrick Bouvier wrote: > Signed-off-by: Pierrick Bouvier > --- A general suggestion for the entire series: please use a commit message that explains why this is a good idea. Even something as boiler-plate as "refer to commit XXX for rationale" that can be

Re: [PATCH 01/39] docs/spin: replace assert(0) with g_assert_not_reached()

2024-09-10 Thread Richard Henderson
On 9/10/24 15:15, Pierrick Bouvier wrote: Signed-off-by: Pierrick Bouvier --- docs/spin/aio_notify_accept.promela | 6 +++--- docs/spin/aio_notify_bug.promela| 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) Reviewed-by: Richard Henderson r~

[PATCH 01/39] docs/spin: replace assert(0) with g_assert_not_reached()

2024-09-10 Thread Pierrick Bouvier
Signed-off-by: Pierrick Bouvier --- docs/spin/aio_notify_accept.promela | 6 +++--- docs/spin/aio_notify_bug.promela| 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/docs/spin/aio_notify_accept.promela b/docs/spin/aio_notify_accept.promela index 9cef2c955dd..f929d303