Re: [PATCH 01/25] qemu-option: clean up id vs. list->merge_lists

2021-01-20 Thread Markus Armbruster
Paolo Bonzini writes: > On 20/01/21 09:03, Markus Armbruster wrote: >> The detour should be avoided, because QemuOpts should be avoided. Using >> the appropriate visitor, we get: >> char *optarg >> | >> | v = qobject_input_visitor_new_str(string, NULL, errp)

Re: [PATCH 01/25] qemu-option: clean up id vs. list->merge_lists

2021-01-20 Thread Paolo Bonzini
On 20/01/21 09:03, Markus Armbruster wrote: The detour should be avoided, because QemuOpts should be avoided. Using the appropriate visitor, we get: char *optarg | | v = qobject_input_visitor_new_str(string, NULL, errp) | visit_type_q_obj_set

Re: [PATCH 01/25] qemu-option: clean up id vs. list->merge_lists

2021-01-20 Thread Markus Armbruster
Paolo Bonzini writes: > On 19/01/21 14:58, Markus Armbruster wrote: >>> qemu_machine_opts ("-M") >>> qemu_find_opts_singleton("machine") >> >> Gone since your commit 4988a4ea4d "vl: switch -M parsing to keyval". > > Which is part of this series and not yet included in QEMU. Hence the > comm

Re: [PATCH 01/25] qemu-option: clean up id vs. list->merge_lists

2021-01-19 Thread Paolo Bonzini
On 19/01/21 14:58, Markus Armbruster wrote: qemu_machine_opts ("-M") qemu_find_opts_singleton("machine") Gone since your commit 4988a4ea4d "vl: switch -M parsing to keyval". Which is part of this series and not yet included in QEMU. Hence the commit message talks about it in the pres

Re: [PATCH 01/25] qemu-option: clean up id vs. list->merge_lists

2021-01-19 Thread Markus Armbruster
Paolo Bonzini writes: > Looking at all merge-lists QemuOptsList outside tests/ > here is how they access their > QemuOpts: > > reopen_opts in qemu-io-cmds.c ("qemu-img reopen -o") > qemu_opts_find(&reopen_opts, NULL) > > empty_opts in qemu-io.c ("q

Re: [PATCH 01/25] qemu-option: clean up id vs. list->merge_lists

2021-01-19 Thread Kevin Wolf
Am 18.01.2021 um 17:30 hat Paolo Bonzini geschrieben: > Looking at all merge-lists QemuOptsList, here is how they access their > QemuOpts: > > reopen_opts in qemu-io-cmds.c ("qemu-img reopen -o") > qemu_opts_find(&reopen_opts, NULL) > > empty_opts in qemu-io.c ("qemu-io open -o") > qe

[PATCH 01/25] qemu-option: clean up id vs. list->merge_lists

2021-01-18 Thread Paolo Bonzini
Looking at all merge-lists QemuOptsList, here is how they access their QemuOpts: reopen_opts in qemu-io-cmds.c ("qemu-img reopen -o") qemu_opts_find(&reopen_opts, NULL) empty_opts in qemu-io.c ("qemu-io open -o") qemu_opts_find(&empty_opts, NULL) qemu_rtc_opts ("-rtc") qe