Re: [PATCH 01/20] xics: Use incomplete type for XICSFabric

2019-09-25 Thread Greg Kurz
On Wed, 25 Sep 2019 16:45:15 +1000 David Gibson wrote: > Interface instances should never be directly dereferenced. So, the common > practice is to make them incomplete types to make sure no-one does that. > XICSFrabric, however, had a dummy type which is less safe. > > Signed-off-by: David Gib

Re: [PATCH 01/20] xics: Use incomplete type for XICSFabric

2019-09-25 Thread Greg Kurz
On Wed, 25 Sep 2019 08:55:50 +0200 Cédric Le Goater wrote: > On 25/09/2019 08:45, David Gibson wrote: > > Interface instances should never be directly dereferenced. So, the common > > practice is to make them incomplete types to make sure no-one does that. > > XICSFrabric, however, had a dummy t

Re: [PATCH 01/20] xics: Use incomplete type for XICSFabric

2019-09-25 Thread Cédric Le Goater
On 25/09/2019 08:45, David Gibson wrote: > Interface instances should never be directly dereferenced. So, the common > practice is to make them incomplete types to make sure no-one does that. > XICSFrabric, however, had a dummy type which is less safe. > > Signed-off-by: David Gibson > --- > in

[PATCH 01/20] xics: Use incomplete type for XICSFabric

2019-09-24 Thread David Gibson
Interface instances should never be directly dereferenced. So, the common practice is to make them incomplete types to make sure no-one does that. XICSFrabric, however, had a dummy type which is less safe. Signed-off-by: David Gibson --- include/hw/ppc/xics.h | 4 +--- 1 file changed, 1 inserti