Re: [PATCH 01/17] replay: Fix migration use of clock for statistics

2024-12-24 Thread Peter Xu
On Tue, Dec 24, 2024 at 10:24:51AM +0300, Pavel Dovgalyuk wrote: > On 23.12.2024 20:26, Peter Xu wrote: > > On Sat, Dec 21, 2024 at 01:02:01PM +1000, Nicholas Piggin wrote: > > > On Sat Dec 21, 2024 at 2:31 AM AEST, Peter Xu wrote: > > > > On Fri, Dec 20, 2024 at 08:42:03PM +1000, Nicholas Piggin w

Re: [PATCH 01/17] replay: Fix migration use of clock for statistics

2024-12-23 Thread Pavel Dovgalyuk
On 23.12.2024 20:26, Peter Xu wrote: On Sat, Dec 21, 2024 at 01:02:01PM +1000, Nicholas Piggin wrote: On Sat Dec 21, 2024 at 2:31 AM AEST, Peter Xu wrote: On Fri, Dec 20, 2024 at 08:42:03PM +1000, Nicholas Piggin wrote: Migration reads CLOCK_HOST when not holding the replay_mutex, which assert

Re: [PATCH 01/17] replay: Fix migration use of clock for statistics

2024-12-23 Thread Peter Xu
On Sat, Dec 21, 2024 at 01:02:01PM +1000, Nicholas Piggin wrote: > On Sat Dec 21, 2024 at 2:31 AM AEST, Peter Xu wrote: > > On Fri, Dec 20, 2024 at 08:42:03PM +1000, Nicholas Piggin wrote: > > > Migration reads CLOCK_HOST when not holding the replay_mutex, which > > > asserts when recording a trace

Re: [PATCH 01/17] replay: Fix migration use of clock for statistics

2024-12-20 Thread Nicholas Piggin
On Sat Dec 21, 2024 at 2:31 AM AEST, Peter Xu wrote: > On Fri, Dec 20, 2024 at 08:42:03PM +1000, Nicholas Piggin wrote: > > Migration reads CLOCK_HOST when not holding the replay_mutex, which > > asserts when recording a trace. These are not guest visible so should > > be CLOCK_REALTIME like other

Re: [PATCH 01/17] replay: Fix migration use of clock for statistics

2024-12-20 Thread Peter Xu
On Fri, Dec 20, 2024 at 08:42:03PM +1000, Nicholas Piggin wrote: > Migration reads CLOCK_HOST when not holding the replay_mutex, which > asserts when recording a trace. These are not guest visible so should > be CLOCK_REALTIME like other statistics in MigrationState, which do > not require the repl

[PATCH 01/17] replay: Fix migration use of clock for statistics

2024-12-20 Thread Nicholas Piggin
Migration reads CLOCK_HOST when not holding the replay_mutex, which asserts when recording a trace. These are not guest visible so should be CLOCK_REALTIME like other statistics in MigrationState, which do not require the replay_mutex. Signed-off-by: Nicholas Piggin --- migration/migration.c | 8