Re: [PATCH 01/17] hw/misc/ivshmem: Fix missing ERRP_GUARD() for error_prepend()

2024-02-29 Thread Zhao Liu
> > @@ -832,6 +832,7 @@ static void ivshmem_write_config(PCIDevice *pdev, > > uint32_t address, > > static void ivshmem_common_realize(PCIDevice *dev, Error **errp) > > { > > +ERRP_GUARD(); > > IVShmemState *s = IVSHMEM_COMMON(dev); > > Error *err = NULL; > > Please remove "er

Re: [PATCH 01/17] hw/misc/ivshmem: Fix missing ERRP_GUARD() for error_prepend()

2024-02-29 Thread Thomas Huth
On 29/02/2024 15.38, Zhao Liu wrote: From: Zhao Liu As the comment in qapi/error, passing @errp to error_prepend() requires ERRP_GUARD(): * = Why, when and how to use ERRP_GUARD() = * * Without ERRP_GUARD(), use of the @errp parameter is restricted: ... * - It should not be passed to error_pre

[PATCH 01/17] hw/misc/ivshmem: Fix missing ERRP_GUARD() for error_prepend()

2024-02-29 Thread Zhao Liu
From: Zhao Liu As the comment in qapi/error, passing @errp to error_prepend() requires ERRP_GUARD(): * = Why, when and how to use ERRP_GUARD() = * * Without ERRP_GUARD(), use of the @errp parameter is restricted: ... * - It should not be passed to error_prepend(), error_vprepend() or * error_a