Re: [PATCH 01/16] qapi/expr.py: Remove 'info' argument from nested check_if_str

2020-09-24 Thread Cleber Rosa
On Tue, Sep 22, 2020 at 05:12:58PM -0400, John Snow wrote: > The function can just use the argument from the scope above. Otherwise, > we get shadowed argument errors because the parameter name clashes with > the name of a variable already in-scope. > > Signed-off-by: John Snow Reviewed-by: Cleb

Re: [PATCH 01/16] qapi/expr.py: Remove 'info' argument from nested check_if_str

2020-09-23 Thread Eduardo Habkost
On Tue, Sep 22, 2020 at 05:12:58PM -0400, John Snow wrote: > The function can just use the argument from the scope above. Otherwise, > we get shadowed argument errors because the parameter name clashes with > the name of a variable already in-scope. > > Signed-off-by: John Snow Reviewed-by: Edua

[PATCH 01/16] qapi/expr.py: Remove 'info' argument from nested check_if_str

2020-09-22 Thread John Snow
The function can just use the argument from the scope above. Otherwise, we get shadowed argument errors because the parameter name clashes with the name of a variable already in-scope. Signed-off-by: John Snow --- scripts/qapi/expr.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)