Re: [PATCH 01/15] s390x: Cleanup cpu resets

2019-11-21 Thread Thomas Huth
On 21/11/2019 14.11, Janosch Frank wrote: > On 11/21/19 1:53 PM, Thomas Huth wrote: >> On 20/11/2019 12.43, Janosch Frank wrote: >>> Let's move the resets into one function and switch by type, so we can >>> use fallthroughs for shared reset actions. [...] >>> +memset(env, 0, offsetof(CPUS39

Re: [PATCH 01/15] s390x: Cleanup cpu resets

2019-11-21 Thread Janosch Frank
On 11/21/19 1:53 PM, Thomas Huth wrote: > On 20/11/2019 12.43, Janosch Frank wrote: >> Let's move the resets into one function and switch by type, so we can >> use fallthroughs for shared reset actions. >> >> Signed-off-by: Janosch Frank >> --- >> hw/s390x/s390-virtio-ccw.c | 3 + >> target/s39

Re: [PATCH 01/15] s390x: Cleanup cpu resets

2019-11-21 Thread Thomas Huth
On 20/11/2019 12.43, Janosch Frank wrote: > Let's move the resets into one function and switch by type, so we can > use fallthroughs for shared reset actions. > > Signed-off-by: Janosch Frank > --- > hw/s390x/s390-virtio-ccw.c | 3 + > target/s390x/cpu.c | 111 -

Re: [PATCH 01/15] s390x: Cleanup cpu resets

2019-11-21 Thread Cornelia Huck
On Thu, 21 Nov 2019 12:32:38 +0100 Janosch Frank wrote: > On 11/21/19 12:10 PM, Cornelia Huck wrote: > > On Wed, 20 Nov 2019 06:43:20 -0500 > > Janosch Frank wrote: > > > >> Let's move the resets into one function and switch by type, so we can > >> use fallthroughs for shared reset actions.

Re: [PATCH 01/15] s390x: Cleanup cpu resets

2019-11-21 Thread Janosch Frank
On 11/21/19 12:10 PM, Cornelia Huck wrote: > On Wed, 20 Nov 2019 06:43:20 -0500 > Janosch Frank wrote: > >> Let's move the resets into one function and switch by type, so we can >> use fallthroughs for shared reset actions. > > Doing that makes sense. > >> >> Signed-off-by: Janosch Frank >> --

Re: [PATCH 01/15] s390x: Cleanup cpu resets

2019-11-21 Thread Cornelia Huck
On Wed, 20 Nov 2019 06:43:20 -0500 Janosch Frank wrote: > Let's move the resets into one function and switch by type, so we can > use fallthroughs for shared reset actions. Doing that makes sense. > > Signed-off-by: Janosch Frank > --- > hw/s390x/s390-virtio-ccw.c | 3 + > target/s390x/cpu

[PATCH 01/15] s390x: Cleanup cpu resets

2019-11-20 Thread Janosch Frank
Let's move the resets into one function and switch by type, so we can use fallthroughs for shared reset actions. Signed-off-by: Janosch Frank --- hw/s390x/s390-virtio-ccw.c | 3 + target/s390x/cpu.c | 111 - 2 files changed, 52 insertions(+), 62 dele