Re: [PATCH 01/12] hw/char: riscv_htif: Avoid using magic numbers

On Tue, Dec 27, 2022 at 4:50 PM Bin Meng wrote: > > The Spike HTIF is poorly documented. The only relevant info we can > get from the internet is from Andrew Waterman at [1]. > > Add a comment block before htif_handle_tohost_write() to explain > the tohost register format, and use meaningful macro

Re: [PATCH 01/12] hw/char: riscv_htif: Avoid using magic numbers

On 12/27/22 03:48, Bin Meng wrote: The Spike HTIF is poorly documented. The only relevant info we can get from the internet is from Andrew Waterman at [1]. Add a comment block before htif_handle_tohost_write() to explain the tohost register format, and use meaningful macros intead of s/intea

[PATCH 01/12] hw/char: riscv_htif: Avoid using magic numbers

The Spike HTIF is poorly documented. The only relevant info we can get from the internet is from Andrew Waterman at [1]. Add a comment block before htif_handle_tohost_write() to explain the tohost register format, and use meaningful macros intead of magic numbers in the codes. While we are here,