Re: [PATCH 01/11] kset: fix documentation for kset_register()

2022-10-21 Thread Luben Tuikov
On 2022-10-20 22:20, Yang Yingliang wrote: > kset_register() is currently used in some places without calling > kset_put() in error path, because the callers think it should be > kset internal thing to do, but the driver core can not know what > caller doing with that memory at times. The memory co

Re: [PATCH 01/11] kset: fix documentation for kset_register()

2022-10-21 Thread Luben Tuikov
On 2022-10-21 04:05, Yang Yingliang wrote: > > On 2022/10/21 13:34, Luben Tuikov wrote: >> On 2022-10-20 22:20, Yang Yingliang wrote: >>> kset_register() is currently used in some places without calling >>> kset_put() in error path, because the callers think it should be >>> kset internal thing to

Re: [PATCH 01/11] kset: fix documentation for kset_register()

2022-10-21 Thread Yang Yingliang via
On 2022/10/21 13:34, Luben Tuikov wrote: On 2022-10-20 22:20, Yang Yingliang wrote: kset_register() is currently used in some places without calling kset_put() in error path, because the callers think it should be kset internal thing to do, but the driver core can not know what caller doing wi

Re: [PATCH 01/11] kset: fix documentation for kset_register()

2022-10-21 Thread Greg KH
On Fri, Oct 21, 2022 at 04:05:18PM +0800, Yang Yingliang wrote: > > On 2022/10/21 13:34, Luben Tuikov wrote: > > On 2022-10-20 22:20, Yang Yingliang wrote: > > > kset_register() is currently used in some places without calling > > > kset_put() in error path, because the callers think it should be

[PATCH 01/11] kset: fix documentation for kset_register()

2022-10-20 Thread Yang Yingliang via
kset_register() is currently used in some places without calling kset_put() in error path, because the callers think it should be kset internal thing to do, but the driver core can not know what caller doing with that memory at times. The memory could be freed both in kset_put() and error path of c