Re: [PATCH 01/10] various: Fix type conflict of GLib function pointers

2025-04-11 Thread Kohei Tokunaga
Hi Paolo, > > On emscripten, function pointer casts can cause function call failure. > > This commit fixes the function definition to match to the type of the > > function call. > > > > - qtest_set_command_cb passed to g_once should match to GThreadFunc > > Sending an alternative patch that doesn'

Re: [PATCH 01/10] various: Fix type conflict of GLib function pointers

2025-04-10 Thread Kohei Tokunaga
Hi Philippe, thank you for the comments. > > +static gpointer g_qtest_set_command_cb( > > +bool (*pc_cb)(CharBackend *chr, gchar **words)) > > +{ > > Why not use a GThreadFunc prototype, casting the argument? Sure, I'll fix this. > OK for the rest, but it might help to merge by corresponding

Re: [PATCH 01/10] various: Fix type conflict of GLib function pointers

2025-04-10 Thread Paolo Bonzini
On 4/7/25 16:45, Kohei Tokunaga wrote: On emscripten, function pointer casts can cause function call failure. This commit fixes the function definition to match to the type of the function call. - qtest_set_command_cb passed to g_once should match to GThreadFunc Sending an alternative patch th

Re: [PATCH 01/10] various: Fix type conflict of GLib function pointers

2025-04-09 Thread Philippe Mathieu-Daudé
Hi Kohei, On 7/4/25 16:45, Kohei Tokunaga wrote: On emscripten, function pointer casts can cause function call failure. This commit fixes the function definition to match to the type of the function call. - qtest_set_command_cb passed to g_once should match to GThreadFunc - object_class_cmp and

[PATCH 01/10] various: Fix type conflict of GLib function pointers

2025-04-07 Thread Kohei Tokunaga
On emscripten, function pointer casts can cause function call failure. This commit fixes the function definition to match to the type of the function call. - qtest_set_command_cb passed to g_once should match to GThreadFunc - object_class_cmp and cpreg_key_compare are passed to g_list_sort as GC