Re: [PATCH 01/10] dp8393x: Mask EOL bit from descriptor addresses

2019-12-14 Thread Finn Thain
On Sat, 14 Dec 2019, Philippe Mathieu-Daud? wrote: > Hi Finn, > > On 12/14/19 2:25 AM, Finn Thain wrote: > > The LSB of descriptor address registers is used as an EOL flag. > > It has to be masked when those registers are to be used as actual > > addresses for copying memory around. But when the

Re: [PATCH 01/10] dp8393x: Mask EOL bit from descriptor addresses

2019-12-14 Thread Philippe Mathieu-Daudé
Hi Finn, On 12/14/19 2:25 AM, Finn Thain wrote: The LSB of descriptor address registers is used as an EOL flag. It has to be masked when those registers are to be used as actual addresses for copying memory around. But when the registers are to be updated the EOL bit should not be masked. Signe

[PATCH 01/10] dp8393x: Mask EOL bit from descriptor addresses

2019-12-13 Thread Finn Thain
The LSB of descriptor address registers is used as an EOL flag. It has to be masked when those registers are to be used as actual addresses for copying memory around. But when the registers are to be updated the EOL bit should not be masked. Signed-off-by: Finn Thain --- hw/net/dp8393x.c | 8 +++