Re: [PATCH 00/33] migration: capture error reports into Error object

2021-02-16 Thread Dr. David Alan Gilbert
* Daniel P. Berrangé (berra...@redhat.com) wrote: > On Mon, Feb 15, 2021 at 07:01:28PM +, Dr. David Alan Gilbert wrote: > > * Daniel P. Berrangé (berra...@redhat.com) wrote: > > > On Mon, Feb 15, 2021 at 06:38:05PM +, Dr. David Alan Gilbert wrote: > > > > One thing to check, and I *think* y

Re: [PATCH 00/33] migration: capture error reports into Error object

2021-02-16 Thread Daniel P . Berrangé
On Mon, Feb 15, 2021 at 07:01:28PM +, Dr. David Alan Gilbert wrote: > * Daniel P. Berrangé (berra...@redhat.com) wrote: > > On Mon, Feb 15, 2021 at 06:38:05PM +, Dr. David Alan Gilbert wrote: > > > One thing to check, and I *think* you're OK, but we have one place where > > > we actually ch

Re: [PATCH 00/33] migration: capture error reports into Error object

2021-02-15 Thread Dr. David Alan Gilbert
* Daniel P. Berrangé (berra...@redhat.com) wrote: > On Mon, Feb 15, 2021 at 06:38:05PM +, Dr. David Alan Gilbert wrote: > > * Daniel P. Berrangé (berra...@redhat.com) wrote: > > > On Mon, Feb 08, 2021 at 01:29:03PM +, Dr. David Alan Gilbert wrote: > > > > * Daniel P. Berrangé (berra...@redh

Re: [PATCH 00/33] migration: capture error reports into Error object

2021-02-15 Thread Daniel P . Berrangé
On Mon, Feb 15, 2021 at 06:38:05PM +, Dr. David Alan Gilbert wrote: > * Daniel P. Berrangé (berra...@redhat.com) wrote: > > On Mon, Feb 08, 2021 at 01:29:03PM +, Dr. David Alan Gilbert wrote: > > > * Daniel P. Berrangé (berra...@redhat.com) wrote: > > > > On Thu, Feb 04, 2021 at 06:22:49PM

Re: [PATCH 00/33] migration: capture error reports into Error object

2021-02-15 Thread Dr. David Alan Gilbert
* Daniel P. Berrangé (berra...@redhat.com) wrote: > On Mon, Feb 08, 2021 at 01:29:03PM +, Dr. David Alan Gilbert wrote: > > * Daniel P. Berrangé (berra...@redhat.com) wrote: > > > On Thu, Feb 04, 2021 at 06:22:49PM +, Dr. David Alan Gilbert wrote: > > > > * Daniel P. Berrangé (berra...@redh

Re: [PATCH 00/33] migration: capture error reports into Error object

2021-02-08 Thread Daniel P . Berrangé
On Mon, Feb 08, 2021 at 02:29:41PM +, Dr. David Alan Gilbert wrote: > * Daniel P. Berrangé (berra...@redhat.com) wrote: > > On Mon, Feb 08, 2021 at 01:29:03PM +, Dr. David Alan Gilbert wrote: > > > * Daniel P. Berrangé (berra...@redhat.com) wrote: > > > > On Thu, Feb 04, 2021 at 06:22:49PM

Re: [PATCH 00/33] migration: capture error reports into Error object

2021-02-08 Thread Dr. David Alan Gilbert
* Daniel P. Berrangé (berra...@redhat.com) wrote: > On Mon, Feb 08, 2021 at 01:29:03PM +, Dr. David Alan Gilbert wrote: > > * Daniel P. Berrangé (berra...@redhat.com) wrote: > > > On Thu, Feb 04, 2021 at 06:22:49PM +, Dr. David Alan Gilbert wrote: > > > > * Daniel P. Berrangé (berra...@redh

Re: [PATCH 00/33] migration: capture error reports into Error object

2021-02-08 Thread Dr. David Alan Gilbert
* Daniel P. Berrangé (berra...@redhat.com) wrote: > On Thu, Feb 04, 2021 at 06:22:49PM +, Dr. David Alan Gilbert wrote: > > * Daniel P. Berrangé (berra...@redhat.com) wrote: > > > Due to its long term heritage most of the migration code just invokes > > > 'error_report' when problems hit. This

Re: [PATCH 00/33] migration: capture error reports into Error object

2021-02-08 Thread Daniel P . Berrangé
On Mon, Feb 08, 2021 at 01:29:03PM +, Dr. David Alan Gilbert wrote: > * Daniel P. Berrangé (berra...@redhat.com) wrote: > > On Thu, Feb 04, 2021 at 06:22:49PM +, Dr. David Alan Gilbert wrote: > > > * Daniel P. Berrangé (berra...@redhat.com) wrote: > > > > Due to its long term heritage most

Re: [PATCH 00/33] migration: capture error reports into Error object

2021-02-04 Thread Daniel P . Berrangé
On Thu, Feb 04, 2021 at 06:22:49PM +, Dr. David Alan Gilbert wrote: > * Daniel P. Berrangé (berra...@redhat.com) wrote: > > Due to its long term heritage most of the migration code just invokes > > 'error_report' when problems hit. This was fine for HMP, since the > > messages get redirected fr

Re: [PATCH 00/33] migration: capture error reports into Error object

2021-02-04 Thread Dr. David Alan Gilbert
* Daniel P. Berrangé (berra...@redhat.com) wrote: > Due to its long term heritage most of the migration code just invokes > 'error_report' when problems hit. This was fine for HMP, since the > messages get redirected from stderr, into the HMP console. It is not > OK for QMP because the errors will

[PATCH 00/33] migration: capture error reports into Error object

2021-02-04 Thread Daniel P . Berrangé
Due to its long term heritage most of the migration code just invokes 'error_report' when problems hit. This was fine for HMP, since the messages get redirected from stderr, into the HMP console. It is not OK for QMP because the errors will not be fed back to the QMP client. This wasn't a terrible