Re: [PATCH 00/17] qom: Spring cleaning

2020-05-04 Thread Paolo Bonzini
On 04/05/20 17:28, Markus Armbruster wrote: >> I reviewed everything except patch 8 and it looks good. Thanks very much! > May I add Reviewed-by: Paolo Bonzini ? > For those 16 yes. Paolo

Re: [PATCH 00/17] qom: Spring cleaning

2020-05-04 Thread Markus Armbruster
Paolo Bonzini writes: > On 28/04/20 18:34, Markus Armbruster wrote: >> Includes one actual bug fix for s390x. > > I reviewed everything except patch 8 and it looks good. Thanks very much! May I add Reviewed-by: Paolo Bonzini ?

Re: [PATCH 00/17] qom: Spring cleaning

2020-05-04 Thread Paolo Bonzini
On 28/04/20 18:34, Markus Armbruster wrote: > Includes one actual bug fix for s390x. I reviewed everything except patch 8 and it looks good. Thanks very much! Paolo

Re: [PATCH 00/17] qom: Spring cleaning

2020-04-28 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200428163419.4483-1-arm...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH 00/17] qom: Spring cleaning Message-id: 20200428163419.4483-1-arm...@redhat.com Type: series

[PATCH 00/17] qom: Spring cleaning

2020-04-28 Thread Markus Armbruster
Includes one actual bug fix for s390x. Markus Armbruster (17): qom: Clearer reference counting in object_initialize_childv() qom: Clean up inconsistent use of gchar * vs. char * qom: Drop object_property_del_child()'s unused parameter @errp qom: Change object_property_get_uint16List() to m