Re: [PATCH 00/16] hw/uefi: add uefi variable service

2023-11-22 Thread Gerd Hoffmann
Hi, > One option I've illustrated before is that have SVSM (or equiv) > expose an encrypted storage service to EDK2. Given the proposed EDK2 > side protocol/modifications for variable storage, I wonder if it is > viable for SVSM (or equiv) to replace QEMU in providing the backend > storage impl

Re: [PATCH 00/16] hw/uefi: add uefi variable service

2023-11-22 Thread Gerd Hoffmann
Hi, > Even during the present patch review, while going through only the > headers thus far, I've already said at least twice that we're going to > have to be super careful about integer overflows and buffer overflows. > Any such problem is no longer a guest<->guest privilege boundary breach > b

Re: [PATCH 00/16] hw/uefi: add uefi variable service

2023-11-21 Thread Daniel P . Berrangé
On Tue, Nov 21, 2023 at 04:58:44PM +0100, Laszlo Ersek wrote: > On 11/20/23 17:50, Gerd Hoffmann wrote: > > On Mon, Nov 20, 2023 at 12:53:45PM +0100, Alexander Graf wrote: > >> Hey Gerd! > >> > >> On 15.11.23 16:12, Gerd Hoffmann wrote: > >>> This patch adds a virtual device to qemu which the uefi

Re: [PATCH 00/16] hw/uefi: add uefi variable service

2023-11-21 Thread Laszlo Ersek
On 11/20/23 17:50, Gerd Hoffmann wrote: > On Mon, Nov 20, 2023 at 12:53:45PM +0100, Alexander Graf wrote: >> Hey Gerd! >> >> On 15.11.23 16:12, Gerd Hoffmann wrote: >>> This patch adds a virtual device to qemu which the uefi firmware can use >>> to store variables. This moves the UEFI variable man

Re: [PATCH 00/16] hw/uefi: add uefi variable service

2023-11-20 Thread Gerd Hoffmann
On Mon, Nov 20, 2023 at 12:53:45PM +0100, Alexander Graf wrote: > Hey Gerd! > > On 15.11.23 16:12, Gerd Hoffmann wrote: > > This patch adds a virtual device to qemu which the uefi firmware can use > > to store variables. This moves the UEFI variable management from > > privileged guest code (mana

Re: [PATCH 00/16] hw/uefi: add uefi variable service

2023-11-20 Thread Alexander Graf
Hey Gerd! On 15.11.23 16:12, Gerd Hoffmann wrote: This patch adds a virtual device to qemu which the uefi firmware can use to store variables. This moves the UEFI variable management from privileged guest code (managing vars in pflash) to the host. Main advantage is that the need to have privi

[PATCH 00/16] hw/uefi: add uefi variable service

2023-11-15 Thread Gerd Hoffmann
This patch adds a virtual device to qemu which the uefi firmware can use to store variables. This moves the UEFI variable management from privileged guest code (managing vars in pflash) to the host. Main advantage is that the need to have privilege separation in the guest goes away. On x86 privi