Re: [PATCH 0/6] RfC: try improve native hotplug for pcie root ports

2021-11-15 Thread Michael S. Tsirkin
On Fri, Nov 12, 2021 at 12:15:28PM +0100, Gerd Hoffmann wrote: > On Thu, Nov 11, 2021 at 10:39:59AM -0500, Michael S. Tsirkin wrote: > > On Thu, Nov 11, 2021 at 01:09:05PM +0100, Gerd Hoffmann wrote: > > > Hi, > > > > > > > When the acpihp driver is used the linux kernel will just call the aml >

Re: [PATCH 0/6] RfC: try improve native hotplug for pcie root ports

2021-11-12 Thread Igor Mammedov
On Fri, 12 Nov 2021 12:15:28 +0100 Gerd Hoffmann wrote: > On Thu, Nov 11, 2021 at 10:39:59AM -0500, Michael S. Tsirkin wrote: > > On Thu, Nov 11, 2021 at 01:09:05PM +0100, Gerd Hoffmann wrote: > > > Hi, > > > > > > > When the acpihp driver is used the linux kernel will just call the aml >

Re: [PATCH 0/6] RfC: try improve native hotplug for pcie root ports

2021-11-12 Thread Gerd Hoffmann
On Thu, Nov 11, 2021 at 10:39:59AM -0500, Michael S. Tsirkin wrote: > On Thu, Nov 11, 2021 at 01:09:05PM +0100, Gerd Hoffmann wrote: > > Hi, > > > > > When the acpihp driver is used the linux kernel will just call the aml > > > methods and I suspect the pci device will stay invisible then becaus

Re: [PATCH 0/6] RfC: try improve native hotplug for pcie root ports

2021-11-12 Thread Gerd Hoffmann
Hi, > involved, but I think it's more a question of luck. This until these > specific patches, but they are only in v2 out of rfc status just today. Never posted a formal non-rfc version because I had no pending changes. Maybe I should have done that ... v2 has no functional changes, it only

Re: [PATCH 0/6] RfC: try improve native hotplug for pcie root ports

2021-11-11 Thread Michael S. Tsirkin
On Thu, Nov 11, 2021 at 06:08:11PM +, Daniel P. Berrangé wrote: > On Thu, Nov 11, 2021 at 12:11:19PM -0500, Michael S. Tsirkin wrote: > > On Thu, Nov 11, 2021 at 09:35:37AM +, Daniel P. Berrangé wrote: > > > On Thu, Nov 11, 2021 at 03:20:07AM -0500, Michael S. Tsirkin wrote: > > > > On Thu,

Re: [PATCH 0/6] RfC: try improve native hotplug for pcie root ports

2021-11-11 Thread Daniel P . Berrangé
On Thu, Nov 11, 2021 at 12:11:19PM -0500, Michael S. Tsirkin wrote: > On Thu, Nov 11, 2021 at 09:35:37AM +, Daniel P. Berrangé wrote: > > On Thu, Nov 11, 2021 at 03:20:07AM -0500, Michael S. Tsirkin wrote: > > > On Thu, Nov 11, 2021 at 08:53:06AM +0100, Gerd Hoffmann wrote: > > > > Hi, > > >

Re: [PATCH 0/6] RfC: try improve native hotplug for pcie root ports

2021-11-11 Thread Michael S. Tsirkin
On Thu, Nov 11, 2021 at 09:35:37AM +, Daniel P. Berrangé wrote: > On Thu, Nov 11, 2021 at 03:20:07AM -0500, Michael S. Tsirkin wrote: > > On Thu, Nov 11, 2021 at 08:53:06AM +0100, Gerd Hoffmann wrote: > > > Hi, > > > > > > > Given it's a bugfix, and given that I hear through internal channel

Re: [PATCH 0/6] RfC: try improve native hotplug for pcie root ports

2021-11-11 Thread Michael S. Tsirkin
On Thu, Nov 11, 2021 at 01:09:05PM +0100, Gerd Hoffmann wrote: > Hi, > > > When the acpihp driver is used the linux kernel will just call the aml > > methods and I suspect the pci device will stay invisible then because > > nobody flips the slot power control bit (with native-hotplug=on, for > >

Re: [PATCH 0/6] RfC: try improve native hotplug for pcie root ports

2021-11-11 Thread Gerd Hoffmann
Hi, > When the acpihp driver is used the linux kernel will just call the aml > methods and I suspect the pci device will stay invisible then because > nobody flips the slot power control bit (with native-hotplug=on, for > native-hotplug=off this isn't a problem of course). Hmm, on a quick smoke

Re: [PATCH 0/6] RfC: try improve native hotplug for pcie root ports

2021-11-11 Thread Daniel P . Berrangé
On Thu, Nov 11, 2021 at 03:20:07AM -0500, Michael S. Tsirkin wrote: > On Thu, Nov 11, 2021 at 08:53:06AM +0100, Gerd Hoffmann wrote: > > Hi, > > > > > Given it's a bugfix, and given that I hear through internal channels > > > that QE results so far have been encouraging, I am inclined to bite th

Re: [PATCH 0/6] RfC: try improve native hotplug for pcie root ports

2021-11-11 Thread Gerd Hoffmann
On Thu, Nov 11, 2021 at 03:20:07AM -0500, Michael S. Tsirkin wrote: > On Thu, Nov 11, 2021 at 08:53:06AM +0100, Gerd Hoffmann wrote: > > Hi, > > > > > Given it's a bugfix, and given that I hear through internal channels > > > that QE results so far have been encouraging, I am inclined to bite th

Re: [PATCH 0/6] RfC: try improve native hotplug for pcie root ports

2021-11-11 Thread Michael S. Tsirkin
On Thu, Nov 11, 2021 at 08:53:06AM +0100, Gerd Hoffmann wrote: > Hi, > > > Given it's a bugfix, and given that I hear through internal channels > > that QE results so far have been encouraging, I am inclined to bite the > > bullet and merge this for -rc1. > > Fine with me. > > > I don't think

Re: [PATCH 0/6] RfC: try improve native hotplug for pcie root ports

2021-11-10 Thread Gerd Hoffmann
Hi, > Given it's a bugfix, and given that I hear through internal channels > that QE results so far have been encouraging, I am inclined to bite the > bullet and merge this for -rc1. Fine with me. > I don't think this conflicts with Julia's patches as users can still > disable ACPI hotplug int

Re: [PATCH 0/6] RfC: try improve native hotplug for pcie root ports

2021-11-10 Thread Michael S. Tsirkin
Given it's a bugfix, and given that I hear through internal channels that QE results so far have been encouraging, I am inclined to bite the bullet and merge this for -rc1. I don't think this conflicts with Julia's patches as users can still disable ACPI hotplug into bridges. Gerd, agree? Worth t

Re: [PATCH 0/6] RfC: try improve native hotplug for pcie root ports

2021-11-02 Thread Gerd Hoffmann
Hi, > > So in theory the guest turning off slot power quickly should work just > > fine and speed up the unplug process in the common case (guest is > > up'n'running and responsitive). Down to 1-2 secs instead of 5-7. > > Didn't actually test that though. Tried mean while, test patch (not poli

Re: [PATCH 0/6] RfC: try improve native hotplug for pcie root ports

2021-11-01 Thread Michael S. Tsirkin
On Tue, Oct 19, 2021 at 08:29:19AM +0200, Gerd Hoffmann wrote: > Hi, > > > > Yes. Maybe ask rh qe to run the patch set through their hotplug test > > > suite (to avoid a apci-hotplug style disaster where qe found various > > > issues after release)? > > > > I'll poke around to see if they can

Re: [PATCH 0/6] RfC: try improve native hotplug for pcie root ports

2021-10-18 Thread Gerd Hoffmann
Hi, > > Yes. Maybe ask rh qe to run the patch set through their hotplug test > > suite (to avoid a apci-hotplug style disaster where qe found various > > issues after release)? > > I'll poke around to see if they can help us... we'll need > a backport for that though. Easy, it's a clean cherr

Re: [PATCH 0/6] RfC: try improve native hotplug for pcie root ports

2021-10-18 Thread Michael S. Tsirkin
On Tue, Oct 19, 2021 at 07:21:44AM +0200, Gerd Hoffmann wrote: > On Mon, Oct 18, 2021 at 11:36:45AM -0400, Michael S. Tsirkin wrote: > > On Mon, Oct 11, 2021 at 02:04:58PM +0200, Gerd Hoffmann wrote: > > > > > > > > > Gerd Hoffmann (6): > > > pci: implement power state > > > pcie: implement s

Re: [PATCH 0/6] RfC: try improve native hotplug for pcie root ports

2021-10-18 Thread Gerd Hoffmann
On Mon, Oct 18, 2021 at 11:36:45AM -0400, Michael S. Tsirkin wrote: > On Mon, Oct 11, 2021 at 02:04:58PM +0200, Gerd Hoffmann wrote: > > > > > > Gerd Hoffmann (6): > > pci: implement power state > > pcie: implement slow power control for pcie root ports > > pcie: add power indicator blink c

Re: [PATCH 0/6] RfC: try improve native hotplug for pcie root ports

2021-10-18 Thread Michael S. Tsirkin
On Mon, Oct 11, 2021 at 02:04:58PM +0200, Gerd Hoffmann wrote: > > > Gerd Hoffmann (6): > pci: implement power state > pcie: implement slow power control for pcie root ports > pcie: add power indicator blink check > pcie: factor out pcie_cap_slot_unplug() > pcie: fast unplug when slot p

[PATCH 0/6] RfC: try improve native hotplug for pcie root ports

2021-10-11 Thread Gerd Hoffmann
Gerd Hoffmann (6): pci: implement power state pcie: implement slow power control for pcie root ports pcie: add power indicator blink check pcie: factor out pcie_cap_slot_unplug() pcie: fast unplug when slot power is off pcie: expire pending delete include/hw/pci/pci.h | 2 ++ inc