Re: [PATCH 0/5] tcg: Dynamically allocate temporaries

2021-01-21 Thread Richard Henderson
On 1/21/21 10:09 AM, BALATON Zoltan wrote: > On Wed, 20 Jan 2021, BALATON Zoltan wrote: >> On Tue, 19 Jan 2021, Richard Henderson wrote: >>> My recent change for caching tcg constants has, in a number of cases, >>> overflowed the statically allocated array of temporaries.  Change to >>> dynamic all

Re: [PATCH 0/5] tcg: Dynamically allocate temporaries

2021-01-21 Thread BALATON Zoltan
On Wed, 20 Jan 2021, BALATON Zoltan wrote: On Tue, 19 Jan 2021, Richard Henderson wrote: My recent change for caching tcg constants has, in a number of cases, overflowed the statically allocated array of temporaries. Change to dynamic allocation. This seems to work for me so Tested-by: BALAT

Re: [PATCH 0/5] tcg: Dynamically allocate temporaries

2021-01-20 Thread BALATON Zoltan
On Wed, 20 Jan 2021, Philippe Mathieu-Daudé wrote: On 1/20/21 12:06 AM, BALATON Zoltan wrote: On Tue, 19 Jan 2021, Richard Henderson wrote: My recent change for caching tcg constants has, in a number of cases, overflowed the statically allocated array of temporaries.  Change to dynamic allocati

Re: [PATCH 0/5] tcg: Dynamically allocate temporaries

2021-01-19 Thread Philippe Mathieu-Daudé
On 1/20/21 12:06 AM, BALATON Zoltan wrote: > On Tue, 19 Jan 2021, Richard Henderson wrote: >> My recent change for caching tcg constants has, in a number of cases, >> overflowed the statically allocated array of temporaries.  Change to >> dynamic allocation. > > This seems to work for me so > > T

Re: [PATCH 0/5] tcg: Dynamically allocate temporaries

2021-01-19 Thread BALATON Zoltan
On Tue, 19 Jan 2021, Richard Henderson wrote: My recent change for caching tcg constants has, in a number of cases, overflowed the statically allocated array of temporaries. Change to dynamic allocation. This seems to work for me so Tested-by: BALATON Zoltan but have you done any performanc

[PATCH 0/5] tcg: Dynamically allocate temporaries

2021-01-19 Thread Richard Henderson
My recent change for caching tcg constants has, in a number of cases, overflowed the statically allocated array of temporaries. Change to dynamic allocation. I'll note that nothing in check-acceptance triggers this overflow. Anyone care to add some more test cases there? Also, there's some outst