Re: [PATCH 0/4] memory: Add memory_region_msync() & make NVMe emulated device generic

2020-05-27 Thread Stefan Hajnoczi
On Fri, May 08, 2020 at 08:24:52AM +0200, Philippe Mathieu-Daudé wrote: > Let the NVMe emulated device be target-agnostic. > > It is not clear if dccvap_writefn() really needs > memory_region_writeback() or could use memory_region_msync(). > > Philippe Mathieu-Daudé (4): > memory: Rename memory

Re: [PATCH 0/4] memory: Add memory_region_msync() & make NVMe emulated device generic

2020-05-21 Thread Philippe Mathieu-Daudé
On 5/21/20 2:46 PM, Paolo Bonzini wrote: On 21/05/20 14:32, Stefan Hajnoczi wrote: On Fri, May 08, 2020 at 08:24:52AM +0200, Philippe Mathieu-Daudé wrote: Let the NVMe emulated device be target-agnostic. It is not clear if dccvap_writefn() really needs memory_region_writeback() or could use m

Re: [PATCH 0/4] memory: Add memory_region_msync() & make NVMe emulated device generic

2020-05-21 Thread Paolo Bonzini
On 21/05/20 14:32, Stefan Hajnoczi wrote: > On Fri, May 08, 2020 at 08:24:52AM +0200, Philippe Mathieu-Daudé wrote: >> Let the NVMe emulated device be target-agnostic. >> >> It is not clear if dccvap_writefn() really needs >> memory_region_writeback() or could use memory_region_msync(). >> >> Phili

Re: [PATCH 0/4] memory: Add memory_region_msync() & make NVMe emulated device generic

2020-05-21 Thread Stefan Hajnoczi
On Fri, May 08, 2020 at 08:24:52AM +0200, Philippe Mathieu-Daudé wrote: > Let the NVMe emulated device be target-agnostic. > > It is not clear if dccvap_writefn() really needs > memory_region_writeback() or could use memory_region_msync(). > > Philippe Mathieu-Daudé (4): > memory: Rename memory

Re: [PATCH 0/4] memory: Add memory_region_msync() & make NVMe emulated device generic

2020-05-08 Thread Paolo Bonzini
On 08/05/20 17:35, Philippe Mathieu-Daudé wrote: >> So I understand I can simply rename memory_region_writeback -> >> memory_region_msync in patch #2. > > (removing the mr->dirty_log_mask). > Yes. Paolo

Re: [PATCH 0/4] memory: Add memory_region_msync() & make NVMe emulated device generic

2020-05-08 Thread Paolo Bonzini
On 08/05/20 17:20, Beata Michalska wrote: >> >> mr->dirty_log_mask tells if dirty tracking has been enabled, not if the >> page is dirty. It would always be true during live migration and when >> running on TCG, but otherwise it would always be false. >> >> Beata, can you explain what you had in m

Re: [PATCH 0/4] memory: Add memory_region_msync() & make NVMe emulated device generic

2020-05-08 Thread Philippe Mathieu-Daudé
On Fri, May 8, 2020 at 5:34 PM Philippe Mathieu-Daudé wrote: > > On 5/8/20 5:33 PM, Paolo Bonzini wrote: > > On 08/05/20 17:20, Beata Michalska wrote: > >>> > >>> mr->dirty_log_mask tells if dirty tracking has been enabled, not if the > >>> page is dirty. It would always be true during live migra

Re: [PATCH 0/4] memory: Add memory_region_msync() & make NVMe emulated device generic

2020-05-08 Thread Philippe Mathieu-Daudé
On 5/8/20 5:33 PM, Paolo Bonzini wrote: On 08/05/20 17:20, Beata Michalska wrote: mr->dirty_log_mask tells if dirty tracking has been enabled, not if the page is dirty. It would always be true during live migration and when running on TCG, but otherwise it would always be false. Beata, can yo

Re: [PATCH 0/4] memory: Add memory_region_msync() & make NVMe emulated device generic

2020-05-08 Thread Beata Michalska
On Fri, 8 May 2020 at 07:33, Paolo Bonzini wrote: > > On 08/05/20 08:24, Philippe Mathieu-Daudé wrote: > > It is not clear if dccvap_writefn() really needs > > memory_region_writeback() or could use memory_region_msync(). > > Indeed, I don't understand the code and why it matters that > mr->dirty_

Re: [PATCH 0/4] memory: Add memory_region_msync() & make NVMe emulated device generic

2020-05-07 Thread Paolo Bonzini
On 08/05/20 08:24, Philippe Mathieu-Daudé wrote: > It is not clear if dccvap_writefn() really needs > memory_region_writeback() or could use memory_region_msync(). Indeed, I don't understand the code and why it matters that mr->dirty_log_mask is nonzero. mr->dirty_log_mask tells if dirty tracking

[PATCH 0/4] memory: Add memory_region_msync() & make NVMe emulated device generic

2020-05-07 Thread Philippe Mathieu-Daudé
Let the NVMe emulated device be target-agnostic. It is not clear if dccvap_writefn() really needs memory_region_writeback() or could use memory_region_msync(). Philippe Mathieu-Daudé (4): memory: Rename memory_region_do_writeback -> memory_region_writeback memory: Extract memory_region_msync(