Re: [PATCH 0/2] osdep: allow including qemu/osdep.h outside extern "C"

2021-04-15 Thread Aleksandar Rikalo
> -- > 2.30.1 From: Philippe Mathieu-Daudé on behalf of Philippe Mathieu-Daudé Sent: Tuesday, April 13, 2021 5:58 PM To: Paolo Bonzini ; qemu-devel@nongnu.org Cc: peter.mayd...@linaro.org ; berra...@redhat.com ; Aleksandar Rikalo ; vince.delvecc...@med

Re: [PATCH 0/2] osdep: allow including qemu/osdep.h outside extern "C"

2021-04-13 Thread Philippe Mathieu-Daudé
Cc'ing MediaTek reviewers. On 4/13/21 1:37 PM, Paolo Bonzini wrote: > qemu/osdep.h is quite special in that, despite being part of QEMU sources, > it is included by C++ source files as well. > > disas/nanomips.cpp is doing so within an 'extern "C"' block, which breaks > with latest glib due to th

Re: [PATCH 0/2] osdep: allow including qemu/osdep.h outside extern "C"

2021-04-13 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20210413113741.214867-1-pbonz...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210413113741.214867-1-pbonz...@redhat.com Subject: [PATCH 0/2] osdep: allow including

[PATCH 0/2] osdep: allow including qemu/osdep.h outside extern "C"

2021-04-13 Thread Paolo Bonzini
qemu/osdep.h is quite special in that, despite being part of QEMU sources, it is included by C++ source files as well. disas/nanomips.cpp is doing so within an 'extern "C"' block, which breaks with latest glib due to the inclusion of templates in glib.h. These patches implement Daniel Berrangé's