Re: [PATCH 0/2] migration: Two fixes around yank and postcopy recovery

2021-06-29 Thread Leonardo Bras Soares Passos
On Tue, Jun 29, 2021 at 3:14 PM Peter Xu wrote: > > The 1st patch should fix yank with unregister instance; I think it should also > fix the issue that Leonardo used to fix in this patch: > > https://lore.kernel.org/qemu-devel/20210629050522.147057-1-leob...@redhat.com/ > > The 2nd patch fixes pos

Re: [PATCH 0/2] migration: Two fixes around yank and postcopy recovery

2021-06-29 Thread Peter Xu
On Tue, Jun 29, 2021 at 07:38:32PM -0300, Leonardo Bras Soares Passos wrote: > > (Leo: please let me know if this series didn't fix the issue you used to > > fix) > > It does fix the issue, as far as I tested. Thanks, Leo! -- Peter Xu

Re: [PATCH 0/2] migration: Two fixes around yank and postcopy recovery

2021-06-29 Thread Peter Xu
On Tue, Jun 29, 2021 at 02:13:54PM -0400, Peter Xu wrote: > Note that the multifd zstd test may fail if run migration-test with sudo on > master (which seems to be a known issue now), and it'll still fail after these > two patches applied, however all running tests keep usual. There's an unexpecte

[PATCH 0/2] migration: Two fixes around yank and postcopy recovery

2021-06-29 Thread Peter Xu
The 1st patch should fix yank with unregister instance; I think it should also fix the issue that Leonardo used to fix in this patch: https://lore.kernel.org/qemu-devel/20210629050522.147057-1-leob...@redhat.com/ The 2nd patch fixes postcopy recovery cannot retry if e.g. the 1st attempt provided