Re: [PATCH 0/2] kvm: clear dirty bitmaps from all overlapping memslots

2019-09-23 Thread Peter Xu
On Mon, Sep 23, 2019 at 06:49:12PM +0200, Paolo Bonzini wrote: > On 23/09/19 18:15, Igor Mammedov wrote: > > Yep, commit message doesn't fit patch, how about following description: > > " > > Currently MemoryRegionSection has 1:1 mapping to KVMSlot. > > However next patch will allow splitting Memory

Re: [PATCH 0/2] kvm: clear dirty bitmaps from all overlapping memslots

2019-09-23 Thread Paolo Bonzini
On 23/09/19 18:15, Igor Mammedov wrote: > Yep, commit message doesn't fit patch, how about following description: > " > Currently MemoryRegionSection has 1:1 mapping to KVMSlot. > However next patch will allow splitting MemoryRegionSection into > several KVMSlot-s, make sure that kvm_physical_log_s

Re: [PATCH 0/2] kvm: clear dirty bitmaps from all overlapping memslots

2019-09-23 Thread Igor Mammedov
On Mon, 23 Sep 2019 09:29:46 +0800 Peter Xu wrote: > On Fri, Sep 20, 2019 at 03:58:51PM +0200, Igor Mammedov wrote: > > On Fri, 20 Sep 2019 20:19:51 +0800 > > Peter Xu wrote: > > > > > On Fri, Sep 20, 2019 at 12:21:20PM +0200, Paolo Bonzini wrote: > > > > A single ram_addr (representing a h

Re: [PATCH 0/2] kvm: clear dirty bitmaps from all overlapping memslots

2019-09-22 Thread Peter Xu
On Fri, Sep 20, 2019 at 03:58:51PM +0200, Igor Mammedov wrote: > On Fri, 20 Sep 2019 20:19:51 +0800 > Peter Xu wrote: > > > On Fri, Sep 20, 2019 at 12:21:20PM +0200, Paolo Bonzini wrote: > > > A single ram_addr (representing a host-virtual address) could be aliased > > > to multiple guest physica

Re: [PATCH 0/2] kvm: clear dirty bitmaps from all overlapping memslots

2019-09-20 Thread Igor Mammedov
On Fri, 20 Sep 2019 20:19:51 +0800 Peter Xu wrote: > On Fri, Sep 20, 2019 at 12:21:20PM +0200, Paolo Bonzini wrote: > > A single ram_addr (representing a host-virtual address) could be aliased > > to multiple guest physical addresses. Since the KVM dirty page reporting > > works on guest physica

Re: [PATCH 0/2] kvm: clear dirty bitmaps from all overlapping memslots

2019-09-20 Thread Peter Xu
On Fri, Sep 20, 2019 at 12:21:20PM +0200, Paolo Bonzini wrote: > A single ram_addr (representing a host-virtual address) could be aliased > to multiple guest physical addresses. Since the KVM dirty page reporting > works on guest physical addresses, we need to clear all of the aliases > when a pag

[PATCH 0/2] kvm: clear dirty bitmaps from all overlapping memslots

2019-09-20 Thread Paolo Bonzini
A single ram_addr (representing a host-virtual address) could be aliased to multiple guest physical addresses. Since the KVM dirty page reporting works on guest physical addresses, we need to clear all of the aliases when a page is migrated, or there is a risk of losing writes to the aliases that