Re: [PATCH 0/2] i386: Adjust CPUID_EXT_PDCM based on enable_pmu at realization

2025-06-17 Thread Paolo Bonzini
Queued, thanks; sorry about the delay. Paolo

Re: [PATCH 0/2] i386: Adjust CPUID_EXT_PDCM based on enable_pmu at realization

2025-03-06 Thread Xiaoyao Li
On 3/7/2025 12:22 AM, Zhao Liu wrote: Hi Xiaoyao, First, it's not a good practice that values in env->features[] cannot be directly used for guest CPUID in void cpu_x86_cpuid(), but require further adjustment there. env->features[] are supposed to be finalized at cpu realization, so that after

Re: [PATCH 0/2] i386: Adjust CPUID_EXT_PDCM based on enable_pmu at realization

2025-03-06 Thread Zhao Liu
Hi Xiaoyao, > First, it's not a good practice that values in env->features[] cannot be > directly used for guest CPUID in void cpu_x86_cpuid(), but require further > adjustment there. env->features[] are supposed to be finalized at cpu > realization, so that after it env->features[] is reliable. >

[PATCH 0/2] i386: Adjust CPUID_EXT_PDCM based on enable_pmu at realization

2025-03-03 Thread Xiaoyao Li
First, it's not a good practice that values in env->features[] cannot be directly used for guest CPUID in void cpu_x86_cpuid(), but require further adjustment there. env->features[] are supposed to be finalized at cpu realization, so that after it env->features[] is reliable. Second, there is one