Re: [PATCH v4 10/22] hw/virtio: move vm_running check to virtio_device_started

2022-11-04 Thread Michael S. Tsirkin
On Thu, Nov 03, 2022 at 05:35:57PM -0400, Michael S. Tsirkin wrote: > On Thu, Nov 03, 2022 at 04:30:48PM -0400, Michael S. Tsirkin wrote: > > On Thu, Nov 03, 2022 at 07:18:30PM +, Alex Bennée wrote: > > > > > > "Michael S. Tsirkin" writes: > > > > > > > On Tue, Aug 02, 2022 at 10:49:58AM +01

Re: [PATCH v4 10/22] hw/virtio: move vm_running check to virtio_device_started

2022-11-03 Thread Michael S. Tsirkin
On Thu, Nov 03, 2022 at 04:30:48PM -0400, Michael S. Tsirkin wrote: > On Thu, Nov 03, 2022 at 07:18:30PM +, Alex Bennée wrote: > > > > "Michael S. Tsirkin" writes: > > > > > On Tue, Aug 02, 2022 at 10:49:58AM +0100, Alex Bennée wrote: > > >> All the boilerplate virtio code does the same thin

Re: [PATCH v4 10/22] hw/virtio: move vm_running check to virtio_device_started

2022-11-03 Thread Michael S. Tsirkin
On Thu, Nov 03, 2022 at 07:18:30PM +, Alex Bennée wrote: > > "Michael S. Tsirkin" writes: > > > On Tue, Aug 02, 2022 at 10:49:58AM +0100, Alex Bennée wrote: > >> All the boilerplate virtio code does the same thing (or should at > >> least) of checking to see if the VM is running before attem

Re: [PATCH v4 10/22] hw/virtio: move vm_running check to virtio_device_started

2022-11-03 Thread Alex Bennée
"Michael S. Tsirkin" writes: > On Tue, Aug 02, 2022 at 10:49:58AM +0100, Alex Bennée wrote: >> All the boilerplate virtio code does the same thing (or should at >> least) of checking to see if the VM is running before attempting to >> start VirtIO. Push the logic up to the common function to av

Re: [PATCH v4 10/22] hw/virtio: move vm_running check to virtio_device_started

2022-11-03 Thread Michael S. Tsirkin
On Tue, Aug 02, 2022 at 10:49:58AM +0100, Alex Bennée wrote: > All the boilerplate virtio code does the same thing (or should at > least) of checking to see if the VM is running before attempting to > start VirtIO. Push the logic up to the common function to avoid > getting a copy and paste wrong.

[PATCH v4 10/22] hw/virtio: move vm_running check to virtio_device_started

2022-08-02 Thread Alex Bennée
All the boilerplate virtio code does the same thing (or should at least) of checking to see if the VM is running before attempting to start VirtIO. Push the logic up to the common function to avoid getting a copy and paste wrong. Signed-off-by: Alex Bennée --- include/hw/virtio/virtio.h | 5 ++