Re: [PATCH v2 20/21] accel/tcg: allow plugin instrumentation to be disable via cflags

2021-02-17 Thread Aaron Lindsay via
On Feb 16 10:34, Alex Bennée wrote: > > Aaron Lindsay writes: > > > On Feb 12 16:04, Alex Bennée wrote: > >> Do you see two stores or one store? I think I got the sense the wrong > >> way around because the store is instrumented before the mmu code, > >> hence should be skipped on a re-instrumen

Re: [PATCH v2 20/21] accel/tcg: allow plugin instrumentation to be disable via cflags

2021-02-16 Thread Alex Bennée
Aaron Lindsay writes: > On Feb 12 16:04, Alex Bennée wrote: >> Do you see two stores or one store? I think I got the sense the wrong >> way around because the store is instrumented before the mmu code, >> hence should be skipped on a re-instrumented block. > > I only see one store between the i

Re: [PATCH v2 20/21] accel/tcg: allow plugin instrumentation to be disable via cflags

2021-02-12 Thread Alex Bennée
Aaron Lindsay writes: > On Feb 12 16:04, Alex Bennée wrote: >> Do you see two stores or one store? I think I got the sense the wrong >> way around because the store is instrumented before the mmu code, >> hence should be skipped on a re-instrumented block. > > I only see one store between the i

Re: [PATCH v2 20/21] accel/tcg: allow plugin instrumentation to be disable via cflags

2021-02-12 Thread Aaron Lindsay via
On Feb 12 16:00, Alex Bennée wrote: > > Alex Bennée writes: > > > Aaron Lindsay writes: > > > >> On Feb 10 22:10, Alex Bennée wrote: > >>> When icount is enabled and we recompile an MMIO access we end up > >>> double counting the instruction execution. To avoid this we introduce > >>> the CF_NO

Re: [PATCH v2 20/21] accel/tcg: allow plugin instrumentation to be disable via cflags

2021-02-12 Thread Aaron Lindsay via
On Feb 12 16:04, Alex Bennée wrote: > Do you see two stores or one store? I think I got the sense the wrong > way around because the store is instrumented before the mmu code, > hence should be skipped on a re-instrumented block. I only see one store between the instruction callback for the store

Re: [PATCH v2 20/21] accel/tcg: allow plugin instrumentation to be disable via cflags

2021-02-12 Thread Alex Bennée
Do you see two stores or one store? I think I got the sense the wrong way around because the store is instrumented before the mmu code, hence should be skipped on a re-instrumented block. On Fri, 12 Feb 2021 at 15:41, Aaron Lindsay wrote: > > On Feb 12 14:43, Alex Bennée wrote: > > Aaron Lindsay

Re: [PATCH v2 20/21] accel/tcg: allow plugin instrumentation to be disable via cflags

2021-02-12 Thread Alex Bennée
Alex Bennée writes: > Aaron Lindsay writes: > >> On Feb 10 22:10, Alex Bennée wrote: >>> When icount is enabled and we recompile an MMIO access we end up >>> double counting the instruction execution. To avoid this we introduce >>> the CF_NOINSTR cflag which disables instrumentation for the ne

Re: [PATCH v2 20/21] accel/tcg: allow plugin instrumentation to be disable via cflags

2021-02-12 Thread Aaron Lindsay via
On Feb 12 14:43, Alex Bennée wrote: > Aaron Lindsay writes: > > On Feb 10 22:10, Alex Bennée wrote: > >> When icount is enabled and we recompile an MMIO access we end up > >> double counting the instruction execution. To avoid this we introduce > >> the CF_NOINSTR cflag which disables instrumentat

Re: [PATCH v2 20/21] accel/tcg: allow plugin instrumentation to be disable via cflags

2021-02-12 Thread Alex Bennée
Aaron Lindsay writes: > On Feb 12 11:22, Alex Bennée wrote: >> Aaron Lindsay writes: >> > On Feb 10 22:10, Alex Bennée wrote: >> >> When icount is enabled and we recompile an MMIO access we end up >> >> double counting the instruction execution. To avoid this we introduce >> >> the CF_NOINSTR

Re: [PATCH v2 20/21] accel/tcg: allow plugin instrumentation to be disable via cflags

2021-02-12 Thread Alex Bennée
Aaron Lindsay writes: > On Feb 10 22:10, Alex Bennée wrote: >> When icount is enabled and we recompile an MMIO access we end up >> double counting the instruction execution. To avoid this we introduce >> the CF_NOINSTR cflag which disables instrumentation for the next TB. >> As this is part of

Re: [PATCH v2 20/21] accel/tcg: allow plugin instrumentation to be disable via cflags

2021-02-12 Thread Aaron Lindsay via
On Feb 12 11:22, Alex Bennée wrote: > Aaron Lindsay writes: > > On Feb 10 22:10, Alex Bennée wrote: > >> When icount is enabled and we recompile an MMIO access we end up > >> double counting the instruction execution. To avoid this we introduce > >> the CF_NOINSTR cflag which disables instrumentat

Re: [PATCH v2 20/21] accel/tcg: allow plugin instrumentation to be disable via cflags

2021-02-12 Thread Alex Bennée
Aaron Lindsay writes: > On Feb 10 22:10, Alex Bennée wrote: >> When icount is enabled and we recompile an MMIO access we end up >> double counting the instruction execution. To avoid this we introduce >> the CF_NOINSTR cflag which disables instrumentation for the next TB. >> As this is part of

Re: [PATCH v2 20/21] accel/tcg: allow plugin instrumentation to be disable via cflags

2021-02-11 Thread Aaron Lindsay via
On Feb 10 22:10, Alex Bennée wrote: > When icount is enabled and we recompile an MMIO access we end up > double counting the instruction execution. To avoid this we introduce > the CF_NOINSTR cflag which disables instrumentation for the next TB. > As this is part of the hashed compile flags we will

[PATCH v2 20/21] accel/tcg: allow plugin instrumentation to be disable via cflags

2021-02-10 Thread Alex Bennée
When icount is enabled and we recompile an MMIO access we end up double counting the instruction execution. To avoid this we introduce the CF_NOINSTR cflag which disables instrumentation for the next TB. As this is part of the hashed compile flags we will only execute the generated TB while coming