Re: [PATCH v1 1/2] hw/tricore: fix inclusion of tricore_testboard

2021-07-20 Thread Alex Bennée
Alex Bennée writes: > Peter Maydell writes: > >> On Tue, 20 Jul 2021 at 10:47, Alex Bennée wrote: >>> >>> >>> Peter Maydell writes: >>> >>> > On Mon, 19 Jul 2021 at 20:52, Alex Bennée wrote: >>> >> >>> >> We inadvertently added a symbol clash causing the build not to include >>> >> the test

Re: [PATCH v1 1/2] hw/tricore: fix inclusion of tricore_testboard

2021-07-20 Thread Alex Bennée
Peter Maydell writes: > On Tue, 20 Jul 2021 at 10:47, Alex Bennée wrote: >> >> >> Peter Maydell writes: >> >> > On Mon, 19 Jul 2021 at 20:52, Alex Bennée wrote: >> >> >> >> We inadvertently added a symbol clash causing the build not to include >> >> the testboard needed for check-tcg. >> >>

Re: [PATCH v1 1/2] hw/tricore: fix inclusion of tricore_testboard

2021-07-20 Thread Peter Maydell
On Tue, 20 Jul 2021 at 10:47, Alex Bennée wrote: > > > Peter Maydell writes: > > > On Mon, 19 Jul 2021 at 20:52, Alex Bennée wrote: > >> > >> We inadvertently added a symbol clash causing the build not to include > >> the testboard needed for check-tcg. > >> > >> Fixes: f4063f9c31 ("meson: Intro

Re: [PATCH v1 1/2] hw/tricore: fix inclusion of tricore_testboard

2021-07-20 Thread Alex Bennée
Peter Maydell writes: > On Mon, 19 Jul 2021 at 20:52, Alex Bennée wrote: >> >> We inadvertently added a symbol clash causing the build not to include >> the testboard needed for check-tcg. >> >> Fixes: f4063f9c31 ("meson: Introduce target-specific Kconfig") >> Signed-off-by: Alex Bennée >> --

Re: [PATCH v1 1/2] hw/tricore: fix inclusion of tricore_testboard

2021-07-19 Thread Philippe Mathieu-Daudé
On 7/19/21 9:50 PM, Alex Bennée wrote: > We inadvertently added a symbol clash causing the build not to include > the testboard needed for check-tcg. > > Fixes: f4063f9c31 ("meson: Introduce target-specific Kconfig") Sorry for the mess, I remember having tested this carefully. OK, so my patch wa

Re: [PATCH v1 1/2] hw/tricore: fix inclusion of tricore_testboard

2021-07-19 Thread Peter Maydell
On Mon, 19 Jul 2021 at 20:52, Alex Bennée wrote: > > We inadvertently added a symbol clash causing the build not to include > the testboard needed for check-tcg. > > Fixes: f4063f9c31 ("meson: Introduce target-specific Kconfig") > Signed-off-by: Alex Bennée > --- > configs/devices/tricore-softmm

[PATCH v1 1/2] hw/tricore: fix inclusion of tricore_testboard

2021-07-19 Thread Alex Bennée
We inadvertently added a symbol clash causing the build not to include the testboard needed for check-tcg. Fixes: f4063f9c31 ("meson: Introduce target-specific Kconfig") Signed-off-by: Alex Bennée --- configs/devices/tricore-softmmu/default.mak | 1 + hw/tricore/Kconfig