Re: [PATCH-for-8.2 v4 09/10] hw/char/pl011: Add transmit FIFO to PL011State

2024-07-17 Thread Philippe Mathieu-Daudé
On 16/11/23 16:48, Juan Quintela wrote: Richard Henderson wrote: On 11/9/23 11:28, Philippe Mathieu-Daudé wrote: @@ -436,6 +438,24 @@ static const VMStateDescription vmstate_pl011_clock = { } }; +static bool pl011_xmit_fifo_state_needed(void *opaque) +{ +PL011State* s = opaque

Re: [PATCH-for-8.2 v4 09/10] hw/char/pl011: Add transmit FIFO to PL011State

2023-11-16 Thread Juan Quintela
Richard Henderson wrote: > On 11/9/23 11:28, Philippe Mathieu-Daudé wrote: >> @@ -436,6 +438,24 @@ static const VMStateDescription vmstate_pl011_clock = { >> } >> }; >> +static bool pl011_xmit_fifo_state_needed(void *opaque) >> +{ >> +PL011State* s = opaque; >> + >> +return !fifo

Re: [PATCH-for-8.2 v4 09/10] hw/char/pl011: Add transmit FIFO to PL011State

2023-11-09 Thread Richard Henderson
On 11/9/23 11:28, Philippe Mathieu-Daudé wrote: @@ -436,6 +438,24 @@ static const VMStateDescription vmstate_pl011_clock = { } }; +static bool pl011_xmit_fifo_state_needed(void *opaque) +{ +PL011State* s = opaque; + +return !fifo8_is_empty(&s->xmit_fifo); +} + +static const VM

[PATCH-for-8.2 v4 09/10] hw/char/pl011: Add transmit FIFO to PL011State

2023-11-09 Thread Philippe Mathieu-Daudé
In order to make the next commit easier to review, introduce the transmit FIFO, but do not yet use it. When migrating from new to old VM: - if the fifo is empty, migration will still work because of the subsection. - if the fifo is not empty, the subsection will be ignored, with the only cons