Re: [PATCH-for-7.1] hw/tpm/tpm_tis: Avoid eventual read overrun

2022-03-31 Thread Philippe Mathieu-Daudé
On 31/3/22 09:50, Marc-André Lureau wrote: Hi On Thu, Mar 31, 2022 at 4:02 AM Philippe Mathieu-Daudé > wrote: From: Philippe Mathieu-Daudé mailto:f4...@amsat.org>> The TPMState structure hold an array of TPM_TIS_NUM_LOCALITIES TPMLocality

Re: [PATCH-for-7.1] hw/tpm/tpm_tis: Avoid eventual read overrun

2022-03-31 Thread Marc-André Lureau
Hi On Thu, Mar 31, 2022 at 4:02 AM Philippe Mathieu-Daudé < philippe.mathieu.da...@gmail.com> wrote: > From: Philippe Mathieu-Daudé > > The TPMState structure hold an array of TPM_TIS_NUM_LOCALITIES > TPMLocality loc[], having TPM_TIS_NUM_LOCALITIES defined as '5'. > > tpm_tis_locality_from_addr

[PATCH-for-7.1] hw/tpm/tpm_tis: Avoid eventual read overrun

2022-03-30 Thread Philippe Mathieu-Daudé
From: Philippe Mathieu-Daudé The TPMState structure hold an array of TPM_TIS_NUM_LOCALITIES TPMLocality loc[], having TPM_TIS_NUM_LOCALITIES defined as '5'. tpm_tis_locality_from_addr() returns up to 3 bits, so 7. While unlikely, Coverity is right to report an overrun. Assert we are in range to