Re: [PATCH-for-5.0 12/12] hw/riscv/sifive_u: Add missing error-propagation code

2020-03-31 Thread Peter Maydell
On Tue, 31 Mar 2020 at 18:02, Philippe Mathieu-Daudé wrote > What about this memory_region_init_rom() call (and later > memory_region_init_ram) using error_fatal, same reasoning right? Yes. -- PMM

Re: [PATCH-for-5.0 12/12] hw/riscv/sifive_u: Add missing error-propagation code

2020-03-31 Thread Philippe Mathieu-Daudé
On 3/26/20 10:55 PM, Peter Maydell wrote: On Wed, 25 Mar 2020 at 19:19, Philippe Mathieu-Daudé wrote: Running the coccinelle script produced: $ spatch \ --macro-file scripts/cocci-macro-file.h --include-headers \ --sp-file scripts/coccinelle/object_property_missing_error_propagat

Re: [PATCH-for-5.0 12/12] hw/riscv/sifive_u: Add missing error-propagation code

2020-03-26 Thread Peter Maydell
On Wed, 25 Mar 2020 at 19:19, Philippe Mathieu-Daudé wrote: > > Running the coccinelle script produced: > > $ spatch \ > --macro-file scripts/cocci-macro-file.h --include-headers \ > --sp-file > scripts/coccinelle/object_property_missing_error_propagate.cocci \ > --keep-comments --s

Re: [PATCH-for-5.0 12/12] hw/riscv/sifive_u: Add missing error-propagation code

2020-03-25 Thread Alistair Francis
On Wed, Mar 25, 2020 at 12:28 PM Philippe Mathieu-Daudé wrote: > > Running the coccinelle script produced: > > $ spatch \ > --macro-file scripts/cocci-macro-file.h --include-headers \ > --sp-file > scripts/coccinelle/object_property_missing_error_propagate.cocci \ > --keep-comments

[PATCH-for-5.0 12/12] hw/riscv/sifive_u: Add missing error-propagation code

2020-03-25 Thread Philippe Mathieu-Daudé
Running the coccinelle script produced: $ spatch \ --macro-file scripts/cocci-macro-file.h --include-headers \ --sp-file scripts/coccinelle/object_property_missing_error_propagate.cocci \ --keep-comments --smpl-spacing --dir hw [[manual check required: error_propagate() might be m